always log to console (stderr) not only if -v is given #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 11, 2019 16:05
The right way to control the verbosity with regards to logging is to change the log level.
vouillon
reviewed
Jul 12, 2019
| with Not_found as e -> ignore (Lwt_log.error "Error: Wrong user"); raise e) | ||
| in | ||
| Lwt_unix.chown (full_path access_file) uid gid >>= fun () -> | ||
| Lwt_unix.chown (full_path warning_file) uid gid >>= fun () -> |
Member
There was a problem hiding this comment.
What happens if ocsigenserver is started as root and calls setuid to change its user ID?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The right way to control the verbosity with regards to logging is to
change the log level.