Remove unused Lwt utils #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Warning: Ocsigen_lib might be used in Eliom (or even other libs). Does Ocsigen Start compile with that version? |
Contributor
Author
|
I can successfully run an ocsigen-start template with this other patch: ocsigen/eliom#818 I couldn't find other occurrences. Removing these functions definitely helps switching to direct-style. |
The redefined '>>=' operators are changed into opens of 'Lwt.Infix', which helps analyzing all Lwt call sites. Other Lwt utils functions are removed when they are not used.
smorimoto
approved these changes
Apr 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The redefined '>>=' operators are changed into opens of 'Lwt.Infix', which helps analyzing all Lwt call sites.
Other Lwt utils functions are removed when they are not used.