Add type annotation to ignored values #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps find ignored Lwt threads, which are a challenge to translate into direct-style concurrency.
Member
|
Can you change the Gihtub Action workflow to build with 4.13 instead of 4.08, which is getting quite old? |
The type annotations constrained 're' version which in turn constrained ocaml's version.
Julow
force-pushed
the
annotate-ignored-values
branch
from
1ddcf4c to
8774eba
Compare
Contributor
Author
|
The CI already runs on 4.14.2, 5.3.0 and 4.08. I changed the PR to not add a constraint on |
vouillon
approved these changes
Apr 23, 2025
Contributor
Author
|
Thanks! |
IMHO having type annotations for ignored values is a strict positive in terms of readability. It also defends against some common issues (such as a type changing from some |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps find ignored Lwt threads, which are a challenge to translate into direct-style concurrency. Ignoring a Lwt thread makes it implicitly fork in the background, which requires an explicit call with other concurrency libraries.
This makes finding these implicit forks a lot easier at the expense of added type annotations.
Occurrences of ignored values were found using this tool. Running this again in the future is not needed and type annotation can be removed later if needed.
Thanks @raphael-proust for suggesting the idea.