PostgreSQL backend for Ocsipersist #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
July 4, 2016 15:25
Can finally start implementing functions now, mostly copy from the sqlite3 backend probably.
jrochel
force-pushed
the
ocsipersist-pgsql
branch
from
0bf3664 to
8e5e467
Compare
jrochel
force-pushed
the
ocsipersist-pgsql
branch
2 times, most recently
from
e8b0e2b to
c962748
Compare
jrochel
force-pushed
the
ocsipersist-pgsql
branch
from
c962748 to
23b1bf7
Compare
| let open_store store = use_pool @@ fun db -> | ||
| create_table db store >> Lwt.return store | ||
|
|
||
| let make_persistent_lazy_lwt ~store ~name ~default = use_pool @@ fun db -> |
Member
There was a problem hiding this comment.
This is racy. Another thread could insert into the table after the select and before we perform the insert ourself.
I think, the best we can do is to repeat the two following commands until one of them succeed (that is, until it returns a non-empty list).
SELECT value FROM %s WHERE key = $1;
INSERT INTO %s VALUES ($1, $2) ON CONFLICT (key) DO NOTHING RETURNING 0;
For compatibility with PostgreSQL < 9.5, we can probably replace the second command with the following one and catch the duplicate-key error:
INSERT INTO %s VALUES ($1, $2);
21e3795 to
8064c11
Compare
jrochel
force-pushed
the
ocsipersist-pgsql
branch
from
92f2e4a to
b0f08ea
Compare
added 2 commits
July 11, 2016 15:42
jrochel
force-pushed
the
ocsipersist-pgsql
branch
from
7d39b76 to
1823669
Compare
| and depends on {{{ sqlite3.cma }}}). | ||
| {{{ ocsipersist-dbm.cma }}} (uses the DBM database); | ||
| {{{ ocsipersist-sqlite.cma }}} (uses the SQLite database | ||
| and depends on {{{ sqlite3.cma }}}); |
Member
There was a problem hiding this comment.
wouldn't be better to point to the opam package name ... ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.