Split implementation and make uri abstract again #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make functor issues easier to debug.
Contributor
|
Edit: I typed a long response with the false assumption that the interface forces the user to produce a I will try to implement this ASAP just to make sure. |
Contributor
|
@Drup, an |
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried several approach, but was more or less forced to do it that way.
@vasilisp : What's your opinion ? I decided to parametrized the wrapped function signature over the whole Xml, instead of a selected subset of it, since it looked more future-proof.
The spliting of directory is to enforce the separation.
A side effect of this change is to make the _f _sigs _types modules visible when just using
tyxml(and not.functor). I used to feel strongly about it, but it doesn't really matter ...