Should `config.toml` set `tab_size` to 2?

[DavisVaughan]

i.e. in https://github.com/ocsmit/zed-r/blob/main/languages/r/config.toml

According to the language metadata section, tab_size is one of the things a language extension can configure:
https://zed.dev/docs/extensions/languages#language-metadata

Zed's default tab_size is 4, but most R code out there in the wild uses a tab_size of 2. It might make sense to align with that.

[aymennasri]

Thanks for pointing that out, i'll test it out and push it if functional.

[aymennasri]

@ocsmit the github action for releasing new versions has a new error about credentials, could you check if your PAT expired?

[ocsmit]

Just regenerated the token. Please try now.

…

On Wed, Apr 30, 2025 at 1:39 PM Aymen ***@***.***> wrote: *aymennasri* left a comment (ocsmit/zed-r#33) <#33 (comment)> @ocsmit <https://github.com/ocsmit> the github action for releasing new versions has a new error <https://github.com/ocsmit/zed-r/actions/runs/14760527398/job/41440113275> about credentials, could you check if your PAT expired? — Reply to this email directly, view it on GitHub <#33 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANIYKALNL6MVDDR254FL53D24EDEXAVCNFSM6AAAAAB4GFENQCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNBSHAYDKMZSGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[aymennasri]

@ocsmit
Just re-ran it, still failing with the same error.

If you have time, check this line. Maybe you need to also update the value of the PAT in the secrets section of the repo?

[ocsmit]

Fixed and triggered rerun - zed-industries/extensions#2542 now has error regarding version bump

On Wed, Apr 30, 2025 at 2:09 PM Aymen ***@***.***> wrote: *aymennasri* left a comment (ocsmit/zed-r#33)

<#33 (comment)> @ocsmit <https://github.com/ocsmit> Just re-ran it, still failing with the same error. If you have time, check this line <https://github.com/ocsmit/zed-r/blob/085cc25fefd50239a7b3df547d9f57c57e56ce5d/.github/workflows/release.yml#L18>. Maybe you need to also update the value of the PAT in the secrets section of the repo? —

…

Reply to this email directly, view it on GitHub <#33 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANIYKALA5MP6KADGEJGFJSD24EGUTAVCNFSM6AAAAAB4GFENQCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNBSHA3TAMBYGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[aymennasri]

Thanks it's all good now, i forgot to update the version in extension.toml.