Merged
Conversation
FossPrime
force-pushed
the
harden-screen-test
branch
from
3895f76 to
7a6b060
Compare
Collaborator
|
Thank you for your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The screen test randomly fails if your window manager takes a little bit longer than normal. Which is particularly the case in large screens such as 4k+ monitors or slow GPUs.
I added an optional 1 second delay if the first attempt fails. In Mocha it runs in parallel, so using interval might slow down other tests without any real benefit... hence why I'm using timeout. Speaking of Mocha, it supports retries and is generally better supported than Jasmine... we should switch. The syntax is very similar.