Skip to content

Conversation

@howardfackrell
Copy link

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the npm dependencies of this project.

Snyk changed the following file(s):

  • package.json

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Prototype Pollution
SNYK-JS-JSYAML-13961110
  631  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Prototype Pollution

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-JSYAML-13961110
Copilot AI review requested due to automatic review settings November 17, 2025 11:02
Copilot finished reviewing on behalf of howardfackrell November 17, 2025 11:04
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates dependencies to address a Prototype Pollution vulnerability (SNYK-JS-JSYAML-13961110) in js-yaml. However, the upgrade from js-yaml v3 to v4 introduces breaking API changes that will cause the application to fail at runtime.

Key Changes:

  • Upgrades js-yaml from ^3.5.5 to ^4.1.1 (major version with breaking changes)
  • Upgrades swagger-client from 3.1.0 to 3.8.10 (likely a transitive dependency update)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"ieee754": "^1.1.8",
"immutable": "^3.x.x",
"js-yaml": "^3.5.5",
"js-yaml": "^4.1.1",
Copy link

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrading js-yaml from v3 to v4 introduces breaking API changes that will cause runtime errors. The code currently uses deprecated methods that were removed in v4:

  • YAML.safeLoad() → should be YAML.load()
  • YAML.safeDump() → should be YAML.dump()

These methods are used in:

  • src/core/plugins/spec/actions.js (lines 68, 126)
  • src/plugins/configs/index.js (line 6)

Before merging this security fix, the codebase must be updated to use the new API. Consider updating the affected files or using js-yaml v3.14.1 which also fixes the security vulnerability without breaking changes.

Suggested change
"js-yaml": "^4.1.1",
"js-yaml": "3.14.1",

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants