feat: Optional EVENT_INGRESS_URI #950
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
METRICSis set tofalseWHY
CloudEvents logging is not essential to run the service. This is for who wanna run the service with minimum requirements. And ceclient is not used when
METRICSis set to false in fact.ISSUE
#949
Since it is an update on main, I did not add any test.
Instead of that, I have quickly checked the behavior with those commands below.
This should not break anything since CloudEvents client is referred only when
METRICSis set totrue.METRICS=false \ PORT=8080 \ GITHUB_APP_ID=11111 \ STS_DOMAIN=test.localhost \ APP_SECRET_CERTIFICATE_FILE=$HOME/tmp/private.pem \ go run cmd/app/main.go❯ http test.localhost:8080 HTTP/1.1 200 OK Content-Length: 80 Content-Type: application/json Date: Fri, 04 Jul 2025 00:49:50 GMT { "msg": "please check documentation for usage: https://github.com/octo-sts/app" }