fix(package): add @octokit/core as peer dependency
#296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JumpLink
added a commit
to ribajs/riba
that referenced
this pull request
Dec 3, 2020
gr2m
requested changes
Dec 3, 2020
Contributor
Author
|
@gr2m I have implemented your change requests and still work with yarn 2 |
gr2m
changed the title
@octokit/core as peer dependency@octokit/core as peer dependency
Contributor
|
🎉 This PR is included in version 4.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes yarn 2 issue: Cannot find module '@octokit/core' or its corresponding type declarations.
fix #207
I have tested is with my current project and it seems to be working.
The issue in my yarn 2 project has disappeared after linking to my local fork with this changes. I can also build @octokit/plugin-rest-endpoint-methods and I can run the rest: