Skip to content

Conversation

@octokitbot
Copy link
Contributor

If there are any new endpoints, then the code changes will likely required an update of @octokit/types. It should have received a pull request as well, merge & release it first. The @octokit/types should be updated automatically shortly after in this pull request.

Make sure to update the commits so that the merge results in helpful release notes, see Merging the Pull Request & releasing a new version.

In general

  • Avoid breaking changes at all costs
  • If there are no typescript or code changes, use a docs prefix
  • If there are typescript changes but no code changes, use fix(typescript) prefix
  • If there are code changes, use fix if a problem was resolved, feat if new endpoints / parameters were added, and feat(deprecation) if a method was deprecated.

gr2m
gr2m previously requested changes Aug 12, 2021
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was a bad release, the operationId does not follow the convention, see github/rest-api-description#504 (review)

@gr2m gr2m dismissed their stale review August 31, 2021 17:51

I was wrong, sorry

@gr2m gr2m changed the title 🚧 GitHub OpenAPI specifications changed feat: .packages.deletePackageForUser(), .packages.deletePackageVersionForUser(), .packages.restorePackageForUser(), .packages.restorePackageVersionForUser(), .secretScanning.listAlertsForOrg() Aug 31, 2021
gr2m
gr2m previously approved these changes Aug 31, 2021
@gr2m gr2m merged commit e166936 into master Aug 31, 2021
@gr2m gr2m deleted the openapi-update branch August 31, 2021 18:23
@github-actions
Copy link
Contributor

🎉 This PR is included in version 5.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants