Skip to content

Refactored third-party modules import and fixed few minor bugs #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Refactored third-party modules import and fixed few minor bugs #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7677447
Remove third-party files and move them to the Node modules
SuperPaintman Feb 21, 2018
9c78fe6
Fix minor bugs
SuperPaintman Feb 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@
"compile": "tsc -watch -p ./",
"postinstall": "node ./node_modules/vscode/bin/install"
},
"dependencies": {
"dom-to-image": "2.6.0",
"vivus": "0.4.2"
},
"devDependencies": {
"typescript": "^2.0.3",
"vscode": "^1.0.0",
Expand Down
2 changes: 0 additions & 2 deletions src/webview/dom2image.js
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions src/webview/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@
</svg>
</div>

<script src="./dom2image.js"></script>
<script src="./vivus.js"></script>
<script src="../../node_modules/dom-to-image/dist/dom-to-image.min.js"></script>
<script src="../../node_modules/vivus/dist/vivus.js"></script>
<script src="./index.js"></script>
</body>
</html>
10 changes: 6 additions & 4 deletions src/webview/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,9 @@ function stripInitialIndent(html, indent) {
const doc = new DOMParser().parseFromString(html, 'text/html')
const initialSpans = doc.querySelectorAll('div > div span:first-child')
for (let i = 0; i < initialSpans.length; i++) {
initialSpans[i].innerText = initialSpans[i].innerText.slice(indent)
const initialSpan = initialSpans[i]
Copy link
Owner

@octref octref Feb 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one line is fine. don't declare unnecessary variables.


initialSpan.textContent = initialSpan.textContent.slice(indent)
}
return doc.body.innerHTML
}
Expand Down Expand Up @@ -141,13 +143,13 @@ obturateur.addEventListener('mouseover', () => {
{
duration: 40,
onReady: () => {
obturateur.classList = 'obturateur filling'
obturateur.className = 'obturateur filling'
}
},
() => {
setTimeout(() => {
isInAnimation = false
obturateur.classList = 'obturateur'
obturateur.className = 'obturateur'
}, 700)
}
)
Expand All @@ -170,7 +172,7 @@ window.addEventListener('message', e => {
snippetContainerNode.style.background = 'none'
}

snippetContainerNode.style.opacity = 1
snippetContainerNode.style.opacity = '1'
}
}
})
Loading