Refactored third-party modules import and fixed few minor bugs #37
Conversation
|
Still, if we can just have a few kbs of minified files why have dependencies pulling everything in? Other than that this looks good. Thanks! |
The first reason is that they (minified files) look like we want to hide them from users, like a virus or other "sick" code. The second reason it that VS Code pull the dependencies on its own (on install). And there is no reason to store them in this repo. |
|
I agree with @SuperPaintman here. I thought there was magic thing going on in |
| const initialSpans = doc.querySelectorAll('div > div span:first-child') | ||
| for (let i = 0; i < initialSpans.length; i++) { | ||
| initialSpans[i].innerText = initialSpans[i].innerText.slice(indent) | ||
| const initialSpan = initialSpans[i] |
There was a problem hiding this comment.
just one line is fine. don't declare unnecessary variables.
|
Well, I went for #40. This is my repo so I do what I like. If you can limit this PR to just the |
Sure, It's totally your choice. If you want to confuse users with minified files - you can do it.
Could you do it on your own? |
3 participants
Good afternoon!
I changed the build system a little:
vivusanddom-to-image)Also I fixed few bugs (mistakes):
innerText->textContentclassList->className- because you assigned string to theclassList