Skip to content

Conversation

@thclark
Copy link
Contributor

@thclark thclark commented Nov 18, 2025

Contents (#102)

IMPORTANT: There is 1 breaking change.

Fixes

  • 💥 BREAKING CHANGE: Eager execution correctly respects execute method

Upgrade instructions

💥 Eager execution correctly respects execute method

When using *Task.enqueue() and *Task.enqueue_later() with GCP_TASKS_EAGER_EXECUTE=True, the returned value will now be the status of the task handler response, rather than the calculated result itself. This allows consistent execution between eager and async tasks in cases where the public execute() method of the *Task class has been overridden

BREAKING-CHANGE: When using *Task.enqueue() and *Task.enqueue_later() with GCP_TASKS_EAGER_EXECUTE=True, the returned value will now be the status of the task handler response, rather than the calculated result itself. This allows consistent execution between eager and async tasks in cases where the public execute() method of the *Task class has been overridden
@thclark thclark merged commit caa4976 into main Nov 18, 2025
23 checks passed
@thclark thclark deleted the eager-execute branch November 18, 2025 18:58
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.12%. Comparing base (2be0e9a) to head (379f2de).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
django_gcp/tasks/tasks.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #102   +/-   ##
=======================================
  Coverage   71.12%   71.12%           
=======================================
  Files          43       43           
  Lines        2092     2092           
=======================================
  Hits         1488     1488           
  Misses        604      604           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants