Skip to content

Conversation

@thclark
Copy link
Contributor

@thclark thclark commented Nov 18, 2025

Contents (#103)

IMPORTANT: There is 1 breaking change.

New features

  • 💥 BREAKING CHANGE: Allow wrapping of execute by subclasses

Upgrade instructions

💥 Allow wrapping of execute by subclasses

This makes a further change to the api of the execute() method following the prior release. Now, the raw result is returned by execute() instead of a result, status tuple. The execute() method now accepts **task_kwargs instead of a raw request body requiring deserialisation. Deserialization and error handling are now managed where they ought to be - in the view.

BREAKING-CHANGE: This makes a further change to the api of the execute() method following the prior release. Now, the raw result is returned by execute() instead of a result, status tuple. The execute() method now accepts **task_kwargs instead of a raw request body requiring deserialisation. Deserialization and error handling are now managed where they ought to be - in the view.
@thclark thclark merged commit efd6f94 into main Nov 18, 2025
4 checks passed
@thclark thclark deleted the allow-execute-wrap branch November 18, 2025 20:05
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.17%. Comparing base (379f2de) to head (c0b8457).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
django_gcp/tasks/views.py 78.57% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
+ Coverage   71.12%   71.17%   +0.04%     
==========================================
  Files          43       43              
  Lines        2092     2092              
==========================================
+ Hits         1488     1489       +1     
+ Misses        604      603       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants