-
Notifications
You must be signed in to change notification settings - Fork 4
Consolidate cloud datafile usage #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate cloud datafile usage #157
Conversation
Codecov Report
@@ Coverage Diff @@
## release/0.1.17 #157 +/- ##
==================================================
+ Coverage 94.77% 94.94% +0.17%
==================================================
Files 55 55
Lines 1569 1622 +53
==================================================
+ Hits 1487 1540 +53
Misses 82 82
Continue to review full report at Codecov.
|
thclark
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems complete in terms of code, but lacking documentation.
I've updated the Architecture slide here to give an image of the four use cases.
Can you add that image (I think you can export as SVG, if not screenshot or png export will do) and and example snippet for each of the four use cases to the documentation please?
…or/consolidate-cloud-datafile-usage
skip_ci_tests
Contents
New Features
Datafileto be used as a context manager for changes to local datafilesDatafile.from_cloudto be used as a context manager for changes to cloud datafilesDatafileto remember where in the cloud it came fromDatafile:get_cloud_metadataupdate_cloud_metadataclear_from_file_cache_get_cloud_location_store_cloud_location_check_for_attribute_conflictDatafilefile or metadata if they haven't changedDatafileGoogleCloudStorageClient.update_metadatamethodDatafilecloud methodsMinor improvements
GoogleCloudStorageClient.get_metadataHashableinstances re-calculate theirhash_valueevery time unless animmutable_hash_valueis explicitly provided (e.g. for cloud datafiles where you don't have the file locally to hash)Identifiable._set_idmethodTesting
Quality Checklist