-
Notifications
You must be signed in to change notification settings - Fork 4
Feature: Tag templates #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
87 commits
Select commit
Hold shift + click to select a range
cd32c92
CLN: Remove filters field from manifest strand in twines
cortadocodes 0c579ae
IMP: Disallow more than one colon in tags
cortadocodes 71d5096
REV: Revert "IMP: Disallow more than one colon in tags"
cortadocodes 551f97d
MRG: Merge remote-tracking branch 'origin/main' into feature/tag-temp…
cortadocodes c5a69b9
DEP: Use new version of twined
cortadocodes fa853cf
IMP: Convert tags to labels
cortadocodes ae8f0ef
REF: Change filtering syntax to filter_name=value
cortadocodes dbc9460
IMP: Add ability to filter by nested attributes/dicts
cortadocodes 4cc19eb
IMP: Add FilterDict
cortadocodes f7d8fea
IMP: Add TagDict and use in Taggable
cortadocodes 5aad839
IMP: Make Datafiles and Datasets taggable again
cortadocodes 3e98232
IMP: Stop logging in Serialisable; always exclude logger field in Ser…
cortadocodes 31f6d22
FIX: Remove Serialisable mixin from LabelSet
cortadocodes 26d40d7
DEP: Use correct twined branch
cortadocodes 8299563
IMP: Allow tags to be added to Taggable as kwargs
cortadocodes 5556be9
TST: Test Taggable
cortadocodes b1ca0c9
TST: Test setting items on TagDict
cortadocodes 0f34a00
TST: Test chaining filters on FilterDict
cortadocodes 1dd629e
TST: Test filters for a TagDict
cortadocodes b7f79bc
FIX: Add tags parameter back to Datafile and Dataset constructors
cortadocodes e43ea63
FIX: Initialise superclass in Taggable mixin
cortadocodes ea66c28
CLN: Remove extra parameters from Label
cortadocodes 515fe70
FIX: Add serialise method to TagDict
cortadocodes ce39fb9
FIX: Deserialise TagDicts properly in Datafile.from_cloud
cortadocodes a2c5d00
TST: Fix Taggable test
cortadocodes 1d2dcff
CLN: Simplify test method
cortadocodes 580d432
FIX: Fix Dataset tags parameter
cortadocodes d92de3d
CLN: Remove unused _FILTERSET_ATTRIBUTE class variables
cortadocodes 29e92fe
REF: Base LabelSet on FilterSet
cortadocodes 73b32b0
REF: Base Label on str
cortadocodes 4a16676
IMP: Allow FilterDicts to be ordered by their values
cortadocodes b6742be
IMP: Allow ignoring of filterables without filtered-for attribute
cortadocodes 187ac5e
IMP: Allow multiple filters in filter containers' filter methods
cortadocodes 8f35468
REF: Use lambda for filter instead of def function
cortadocodes 4c75cb0
IMP: Add Dataset.get_file_by_tag
cortadocodes 65be685
CLN: Remvove unnecessary class variable; use more pythonic method ove…
cortadocodes 7da5b64
CLN: Remove commented-out code
cortadocodes 51b5be4
DEP: Use latest GCS emulator
cortadocodes 9ed62c7
FIX: Handle timestamps from cloud with/without timezone information
cortadocodes d53f518
IMP: Limit allowed tag name and label patterns
cortadocodes 75c183a
IMP: Raise error if non-Filterables are put into filter containers
cortadocodes 0f826b4
IMP: Store tags in separate custom metadata fields on GCS
cortadocodes b0b879d
DOC: Fix incorrect/outdated information in docs
cortadocodes a2750a8
REF: Slightly simplify Taggable and Labelable
cortadocodes 84f0a03
FIX: Make Analysis taggable again
cortadocodes 0a570b3
DOC: Update templates with labels/tags
cortadocodes 2aa0ac3
REF: Simplify Datafile.metadata method
cortadocodes ebc11b5
TST: Test that datafile tags are stored as separate pieces of custom …
cortadocodes 19e0864
REV: Remove Dataset.get_file_by_tag method
cortadocodes de967dd
DOC: Update docstrings and error messages
cortadocodes d04f579
REV: Unbase TagDict from FilterDict
cortadocodes dad9ecf
REV: Unbase Label from Filterable and LabelSet from FilterSet
cortadocodes 7d025ab
TST: Remove unneeded base class from test class
cortadocodes fbc058a
TST: Remove unnecessary casting to set
cortadocodes ab893a2
TST: Add wrongly-removed test back in
cortadocodes 1cd5d77
DOC: Fix error string
cortadocodes bf6dec7
TST: Test failing of filtering Filterables with differing attributes;…
cortadocodes ad7afa5
TST: Simplify label tests
cortadocodes 9b0725a
TST: Add tags to datasets in manifest tests
cortadocodes 7e16fe8
TST: Improve and simplify some more tests
cortadocodes 19c1891
TST: Test uncovered areas
cortadocodes 00912a1
IMP: Use new format for manifests' datasets in twine.json files
cortadocodes bfccca7
IMP: Support non-English characters in case-insensitive filtering
cortadocodes 05e6d5d
REF: Base filter containers on new FilterContainer abstract class
cortadocodes 0446498
IMP: Return items when ordering FilterDict rather than just values
cortadocodes 2b56d44
DOC: Update filter containers documentation
cortadocodes 55035fc
DOC: Update other documentation
cortadocodes 9e7d012
MRG: Merge remote-tracking branch 'origin/release/0.1.19' into featur…
cortadocodes d0b48dc
CLN: Remove unnecessary pass statements
cortadocodes 1189a39
IMP: Add octue SDK version to datafile metadata
cortadocodes a2c3d98
IMP: Add `one` method to filter containers
cortadocodes e160ed7
TST: Update tests
cortadocodes 6ad724e
REF: Move filter and order methods into FilterContainer
cortadocodes 4cae5da
MRG: Merge remote-tracking branch 'origin/release/0.1.19' into featur…
cortadocodes b7b920e
IMP: JSON-encode cloud storage custom metadata
cortadocodes 18912ea
REV: Store tags in tags field of cloud metadata again
cortadocodes 97c5aab
REF: Rename GoogleCloudStorageClient methods; update docstrings
cortadocodes d1f26c9
DOC: Update filter container docstrings
cortadocodes af3a2ac
FIX: Allow ordering by nested attributes in other FilterContainers
cortadocodes cd90140
REF: Refactor Dataset.get_file_by_label
cortadocodes 87e0f2b
IMP: Allow UserStrings to be JSON-encoded by default
cortadocodes 52355b2
IMP: Add set serialisation to en/decoders
cortadocodes 1793d1e
REF: Remove unnecessary methods from LabelSet
cortadocodes e5ba7d8
DOC: Document label module
cortadocodes 8c5bdfa
REF: Remove method from TagDict; document methods
cortadocodes 66b4924
FIX: Restore required method
cortadocodes 484ff4d
REF: Rename add_labels method and add `add` method to Label
cortadocodes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't the id a uuid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is for
Identifiablesbut this is just metadata for any given file (this isn't a method of anIdentifiable)