Skip to content

Conversation

@cortadocodes
Copy link
Member

@cortadocodes cortadocodes commented May 25, 2021

Contents

New Features

  • Allow gs:// paths to be used in Datafile, Dataset, and Manifest
  • Allow gs:// paths to be used in storage client

Minor fixes and improvements

  • Remove a line of duplicated code in Datafile

Quality Checklist

  • New features are fully tested (No matter how much Coverage Karma you have)

@cortadocodes cortadocodes self-assigned this May 25, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 25, 2021

Codecov Report

Merging #169 (87d1a53) into release/0.1.19 (fe3a8a0) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release/0.1.19     #169      +/-   ##
==================================================
+ Coverage           95.01%   95.07%   +0.06%     
==================================================
  Files                  55       55              
  Lines                1626     1646      +20     
==================================================
+ Hits                 1545     1565      +20     
  Misses                 81       81              
Impacted Files Coverage Δ
octue/cloud/storage/client.py 97.53% <100.00%> (+0.23%) ⬆️
octue/mixins/serialisable.py 100.00% <100.00%> (ø)
octue/resources/datafile.py 99.05% <100.00%> (+<0.01%) ⬆️
octue/resources/dataset.py 100.00% <100.00%> (ø)
octue/resources/manifest.py 94.59% <100.00%> (+0.22%) ⬆️
octue/utils/encoders.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe3a8a0...87d1a53. Read the comment docs.

@cortadocodes cortadocodes requested a review from thclark May 25, 2021 15:44
@thclark thclark self-requested a review June 2, 2021 12:08
@cortadocodes cortadocodes merged commit 3f42b01 into release/0.1.19 Jun 2, 2021
@cortadocodes cortadocodes deleted the feature/allow-gs-uris-for-cloud-objects branch June 2, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants