add macos secrets support via a /tmp entry#207
Open
avsm wants to merge 3 commits into
Open
Conversation
Member
|
|
Filename.temp_dir is OCaml 5.1+, but workers run 4.14. Switch to Lwt_io.with_temp_dir, matching the pattern in sandbox.runc/jail/hcs and docker_sandbox. As a bonus the directory is now removed on failure and cancellation as well as success, so cleanup_secrets goes away. Tighten the staging dir from 0o755 to 0o711 so other local users can't enumerate secret filenames; the build user only needs traverse.
macos secrets: use Lwt_io.with_temp_dir for staging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This departs from Docker conventions since /run isnt writeable on macOS, so we expose a dedicated environment variable to point the job to where the secrets are held.
Untested until @mtelvers gets access back to the obuilder hosts again :-)