Migrate Firebase compat usages to modular API#616
Merged
Conversation
Add behavioral tests to saveLockDate (firebase set + resolve), replace the trivial "should be a function" assertion. Add addMovementToState happy path (admin, not last element), last-element skip path, createDelegate, and monitorAssociation direct function tests to movements/sagas.spec.js.
- Action: dataCy prop forwarded to StyledAction as data-cy
- Movement: dataCy="action-edit" and "action-delete" on edit/delete Actions
- MovementDeleteConfirmationDialog: dataCy="delete-confirm" on DeleteButton
- AdminNavigation: data-cy={item.key} on each MenuItem
- LockMovementsForm: dataCy="lock-date" passed to DatePicker
- MessageForm/renderField: data-cy={input.name} on Input and TextArea
- MessageForm: dataCy="send" on submit Button
The location-confirmation dialog is shown only after an async Firebase
check resolves. The previous `cy.get('body').then()` ran synchronously
before the response arrived, missing the dialog and causing the test to
time out waiting for the page-5 remarks field.
Replace with a combined-selector `cy.get()` that waits up to 8 s for
either the dialog confirm button or the remarks field to appear, then
conditionally clicks the dialog if it was shown.
rzueger
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.