Conversation
Move all function triggers and HTTPS handlers to europe-west1 to keep processing in Europe. Two functions (scheduledAircraftListUpdate, updateArrivalPaymentStatusOnCardPaymentUpdate) were already there; this brings the remainder in line. Update firebase.json hosting rewrite, all frontend Cloud Function URLs, the Cypress auth endpoint, and documentation accordingly.
The fill-in guard in addMovementToState was skipping re-insertion of a movement when it ended up as the last element in the sorted list. This guard exists to prevent spurious movementAdded fill-in events (fired by Firebase when a preceding movement is deleted) from expanding the visible range. It must not apply when called from movementChanged, where the movement is legitimately being re-inserted after an update. Passing applyFillInGuard=true only from movementAdded and false from movementChanged fixes the case where a single-item list would lose its movement on every onChildChanged event (e.g. triggered by the enrichDepartureOnCreate Cloud Function updating aerodrome metadata).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.