Convert 20 trivial class components to functional#695
Merged
Conversation
Replace PureComponent classes with arrow functions, replace withTranslation() HOC with useTranslation() hook, and replace defaultProps with default parameter values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
withTranslation()HOC withuseTranslation()hook (8 components)defaultPropswith default parameter values (5 components)childrenpropType to DetailsBox andtimeWithDatepropType to MovementHeader (previously hidden by<any, any>generic)jest.mock('react-i18next')to HomeBaseIcon testConverted components: ValidationMessage, DetailsBox, Main, MaterialIcon, MovementField, FieldSet, ImageButton, WizardNavigation, WizardBreadcrumbs, JumpNavigation, HomeBaseIcon, Header, EntryPoints, Hints, MovementGroup, MovementDetails, Action, MovementHeader
No
React.memoadded — these are simple presentational components where shallow comparison overhead outweighs render cost.Test plan
npm run typecheckpassesnpm test— all 1738 tests pass, snapshots unchanged