Fix wizard crash on double-submit with async predicate#696
Merged
Conversation
submitPage did not return the dialog predicate promise, so react-final-form considered the submission instantly complete and accepted re-submissions. Two rapid submits on page 4 (DepartureArrivalPage) launched two async aerodromeExists lookups that both resolved and dispatched nextPage, pushing wizard.page past the pages array bounds. Returning the promise lets react-final-form block re-submission while the predicate is in flight. Fixes JAVASCRIPT-REACT-5C, JAVASCRIPT-REACT-50, JAVASCRIPT-REACT-5A, JAVASCRIPT-REACT-58, JAVASCRIPT-REACT-55, JAVASCRIPT-REACT-52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
submitPageinMovementWizarddid not return the dialog predicate promise, so react-final-form considered the submission instantly complete and accepted re-submissionsaerodromeExistslookups that both resolved and dispatchednextPage, pushingwizard.pagepast the pages array bounds →TypeError: Cannot read properties of undefined (reading 'component')Fixes JAVASCRIPT-REACT-5C, JAVASCRIPT-REACT-50, JAVASCRIPT-REACT-5A, JAVASCRIPT-REACT-58, JAVASCRIPT-REACT-55, JAVASCRIPT-REACT-52
Test plan
aerodromeExistsand double-clicking Next on page 4npm run typecheckpasses