Convert 7 UI primitive class components to functional#700
Merged
Conversation
Convert Button, Dropdown, SingleSelect, IncrementationField, LabeledComponent, ClipboardCopier, and QrCodeGenerator from class components to functional components with hooks. Replace PropTypes with TypeScript interfaces. Replace componentWillReceiveProps/componentDidUpdate prop-to-state sync with render-time sync pattern to avoid visual flash. Use useRef for Dropdown's async onBlur to prevent stale closure reads. Replace withTranslation HOC with useTranslation hook in QrCodeGenerator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useEffect) for prop-to-state synchronization in Dropdown and SingleSelect, preserving the originalcomponentWillReceiveProps/componentDidUpdatetiming to avoid visual flashuseReffor Dropdown's asynconBlurcallback to prevent stale closure inrequestAnimationFramewithTranslation()HOC withuseTranslation()hook in QrCodeGeneratorTest plan
npm test— 1746 tests passnpm run typecheck— clean