Fix Dropdown scrollbar, arrow navigation, and scroll speed#701
Merged
Fix Dropdown scrollbar, arrow navigation, and scroll speed#701
Conversation
Clicking the scrollbar of the options list caused it to disappear because the input blur hid the menu. Prevent focus loss with preventDefault on the options container mousedown, and explicitly close the menu on selection. Arrow key navigation could move focus beyond the rendered options (past optionsRenderLimit) into invisible territory. Limit navigation to the rendered slice. Reduce scroll-into-view animation from 1000ms to 50ms so keyboard navigation feels responsive. Strengthen Dropdown tests to verify arrow key behavior through observable side effects (arrow + Enter = selection) instead of element-existence checks that always pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
preventDefaulton OptionsContainermousedownto keep focus on the input, plus explicitsetInputFocused(false)on selection so options still close after picking a value.optionsRenderLimitare rendered. Pressing arrow down past the last rendered option moved focus to invisible items. Fixed by slicing the navigation array to match the render limit.scroll-into-viewlibrary defaults to 1000ms animation. Reduced to 50ms for responsive keyboard navigation with just enough motion to maintain spatial context.Test plan
npm test— 1749 tests passnpm run typecheck— clean