Merge selected environment config into __CONF__#710
Merged
Conversation
Keys defined under projectConf.environments.<env> now override the top-level config before it is packinized into __CONF__, letting the client read env-specific flags via __CONF__.<key>. Enables per-env feature toggles without introducing new webpack globals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
projectConf.environments.<env>now override the top-level config before it is packinized into__CONF__.__CONF__.<key>directly.Motivation
Today webpack already picks the per-environment block (test vs production) to derive the Firebase globals (
__FIREBASE_PROJECT_ID__, etc.). But everything else in__CONF__is project-wide. If a project wants an opt-in flag that istruein test andfalsein prod (or vice versa), the only way is another top-level webpack global — which doesn't scale.With this change, a project can define under
environments.test(orenvironments.production) any key that is also accepted at the top level, and the selected environment's value wins at build time.Test plan
npm test— all 1806 tests passnpm run typecheckcleannpm run build --project=<any>produces a working bundle