Use shared Button component in PWA install card#714
Merged
Conversation
Swap the PWA install card's custom styled button for the shared <Button> component so it matches the passkey prompt tile rendered next to it. Both cards now use the same app-wide button style (box-shadow, uppercase label, theme-primary fill).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Swap the PWA install card's custom styled
InstallButtonfor the shared<Button>component so it matches the passkey prompt tile when both are rendered side-by-side on the start page.Why
After #713 moved
PostLoginPasskeyPromptto the shared<Button>, the two cards on the start page had mismatched CTAs:<Button>— uppercase, 2px radius, box-shadow, 1.2em fontInstallButton— title case, 5px radius, no shadow, 1em fontSide-by-side this reads as inconsistent. Now both use the same button.
Changes
InstallButtonstyled component<Button primary label={...} onClick={install} dataCy="install-button" />insteaddata-testid(the shared component exposesdata-cy)No behaviour change — the button still calls
install()on click and the card still hides immediately.Test plan
localhost:8080with both tiles forced visible