Merged
Conversation
Opt lspl-test into the passkeysEnabled flag via environments.test. Production remains untouched (inherits the default false from projects/default.json). Functions config (webauthn.rpid, webauthn.origins) was set separately via firebase functions:config:set against the lspl-test project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Opt
lspl-testinto the passkey login feature flag.projects/lspl.json:passkeysEnabled: trueunderenvironments.testonly.passkeysEnabled: falsefromprojects/default.json).webauthn.rpid=lspl-test.web.app,webauthn.origins=https://lspl-test.web.app) already set on thelspl-testFirebase project.Effect after merge
CI rebuilds and redeploys
lspl-test; users onhttps://lspl-test.web.appcan register passkeys from the profile page and the start-page prompt, and use them to sign in. OTP remains the baseline.