Feat/stop cluster #109
Merged
Feat/stop cluster #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add CLUSTER_NAME and KUBECTL_CONTEXT constants as single source of truth - Add ShutdownProgress struct for tracking shutdown state - Add PortForwardRegistry for PID-scoped port-forward cleanup - Add AppMode::ShutdownProgress variant for shutdown UI - Add stop_port_forwards(), delete_cluster(), run_shutdown() functions - Add Ctrl+Q key handler in Dashboard mode (plain Q unchanged) - Add shutdown progress modal with spinner and status display - Update help bar to show '^Q Shutdown' - Replace all hardcoded 'kind-task-observatory' with KUBECTL_CONTEXT - Add 20s auto-retry interval to web terminal for disconnect recovery - Add __odtoTestHooks for Playwright testing of reconnect behavior - Add retry-on-disconnect.spec.ts visual test - Update README cleanup section with TUI shutdown option - Add comprehensive unit tests for new shutdown functionality Addresses critical concerns: - PID-scoped cleanup avoids killing unrelated kubectl processes - Cluster name from constant prevents drift between create/delete - Web retry test ensures graceful disconnect handling
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛑 Add Cluster Shutdown Feature (Ctrl+Q)
Summary
Adds a safe, one-keystroke shutdown feature to the TUI dashboard. Press Ctrl+Q to stop app-started port-forwards, delete the Kind cluster, and exit. Plain Q remains non-destructive.
Features
Safety Improvements
Changes
Testing
Demo
Shutdown modal shows cluster deletion progress and exits cleanly.