Feat/cleanup #97
Merged
Feat/cleanup #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed critical bug where TUI cluster launch failed due to mismatched Docker build contexts: - gateway: Context changed from '.' to 'src/services/gateway' (Dockerfile uses service-relative paths like 'COPY package.json') - processor: Context changed from '.' to 'src/services/processor' (Dockerfile uses service-relative paths like 'COPY requirements.txt') - web-pty-server: Context changed from 'src/services/web-pty-server' to '.' (Dockerfile uses repo-root paths like 'COPY src/services/...') Added clarifying comments explaining the context requirements.
Fixed critical bug where start-all.ps1 built images with VERSION tags
but K8s manifests expected different tags, causing pod creation failures.
Changes:
- scripts/start-all.ps1: Fixed build contexts for gateway/processor/web-pty-server
- src/services/gateway/Dockerfile: Updated BUILD CONTEXTS comment
- src/services/processor/Dockerfile: Updated BUILD CONTEXTS comment
- infra/k8s/web-pty-ws.yaml: Changed :latest to :0.1.0, added version label
- infra/k8s/web-ui-http.yaml: Changed :latest to :0.1.0, added version label
- src/interfaces/web/VERSION: Added (0.1.0) for consistent versioning
- scripts/check-service-versions.py: Extended to check web-pty-server and web-ui
CI Enforcement:
- check-service-versions.py now validates all 6 services have matching
VERSION files and K8s manifest image tags
- Script runs in CI and will fail if :latest is used for any service
Fixes TUI cluster launch failure ('Failed to build: web-pty-server')
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Empty string from K8s secret was being treated as 'auth enabled with empty password' instead of 'auth disabled'. Now empty string is converted to None, matching the documented behavior in web-pty-ws.yaml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.