Skip to content

feat: separate review settings for proactive reviews#82

Merged
oddur merged 1 commit intomainfrom
feat/proactive-review-settings
Apr 20, 2026
Merged

feat: separate review settings for proactive reviews#82
oddur merged 1 commit intomainfrom
feat/proactive-review-settings

Conversation

@oddur
Copy link
Copy Markdown
Owner

@oddur oddur commented Apr 20, 2026

Summary

Lets users opt into a different provider/model/thinking for proactive (background) reviews while keeping their main settings for manual, hand-picked PRs. Typical use: Opus + thinking for manual, Sonnet no-thinking for background.

How it works

  • New `proactiveReviewOverrides` toggle in Settings → Proactive block (only visible when Proactive mode is on).
  • When the toggle is on, revealed controls mirror the HomePage provider/model chip pattern, plus an "Extended thinking" toggle.
  • `triggerProactiveReview` in `src/main.ts` reads the override fields when the toggle is on, falls back to the regular prefs otherwise.
  • Pending history entry now reflects the model that actually runs (previously always showed `prefs.model`).

Defaults

Override is off by default. When first enabled, defaults are Claude / Sonnet 4.6 / thinking off — fast and cheap, which is the point of the feature.

Files

  • `lib/types.ts` — 4 new Preferences fields
  • `src/main.ts` — override logic in `triggerProactiveReview` + defaults
  • `components/SettingsDialog.tsx` — UI (inside the existing proactive block)

Test plan

  • Toggle Proactive mode on, toggle override on, set to Sonnet — next proactive review run logs `claude-sonnet-4-6`.
  • Toggle override off — proactive run uses the regular `prefs.model`.
  • Manual review from HomePage is unaffected either way.
  • History entry for a proactive review shows the model that actually ran.
  • Switching Provider in the override flips the Model list and picks the first available model.

🤖 Generated with Claude Code

Adds opt-in provider/model/thinking overrides used only by the
proactive review flow. Lets users run background reviews on a faster
or cheaper model (e.g. Sonnet with no thinking) while keeping their
manual default (e.g. Opus with thinking) for hand-picked PRs.

- lib/types.ts: new Preferences fields (proactiveReviewOverrides,
  proactiveProvider, proactiveModel, proactiveThinking).
- src/main.ts: triggerProactiveReview reads the overrides when
  enabled, falls back to regular prefs otherwise. Pending history
  entry now reflects whichever model actually runs.
- components/SettingsDialog.tsx: new controls revealed inside the
  proactive-mode block when the override toggle is on. Matches the
  HomePage provider/model chip pattern.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@oddur oddur merged commit 37fdc44 into main Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant