feat(pr-tracker): simplify config to use source channel defaults#203
Merged
feat(pr-tracker): simplify config to use source channel defaults#203
Conversation
- Remove target channel picker/storage: polls post back to the source channel they were scanned from - Remove tracker-level agent override and global defaultAgentProvider; scheduler uses getChannelAgentProvider(sourceChannelId) - Switch poll interval UI to minutes (30-min default); DB still stores seconds so existing rows/migrations aren't touched - Add Switch UI component; replace per-tracker Enable/Disable button - Shrink the three per-tracker action buttons to 32px squares - Legacy DB columns (agent_provider, target_*) kept for backwards compat - Bump version to 0.1.36
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a06e9a4f56
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex review caught that the inner <button on:click={toggle}> in Switch
doesn't forward clicks to the parent component, so the PR tracker
page's on:click handler for the enable switch never ran — the UI
toggled locally but no PUT was sent to the backend. Dispatch a
typed 'change' event with the new checked value and listen via
on:change in the caller.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getChannelAgentProvider), so each channel's agent choice applies uniformly.Switchcomponent replaces the Enable/Disable button per tracker; the three action buttons (Poll now / expand / delete) are shrunk to 32 px squares for a tighter row.agent_provider,target_*,default_agent_provider) are intentionally retained on disk so old rows still load; they're just no longer read or written.Notes
parseTrackerUpdate/parseSettingsUpdateno longer acceptagentProvider,defaultAgentProvider, ortargetChannelId. Existing clients sending those fields are tolerated (fields are ignored).ode pr-trackerCLI loses--target-channel,--agent, and--set-agent; help + rendering updated.0.1.36.Tests
bun test→ 372 pass, 1 skip, 0 failpackages/web-uisvelte-check→ 0 errors