feat: support multiple manifest from one profile and migrate kratos specific ones #2870
Conversation
RonFed
left a comment
RonFed
left a comment
There was a problem hiding this comment.
Since we're deprecating the individuall actions CRD, I think it os a good chance to make the k8sattributes action into the generic one - as this PR adds permissions and code that handles the deprecated one - it might be better to do in the new way and this would also help us for future profiles regarding other actions (all under the generic one).
Don'r want to block on this, I just think it will be nice to have - to move the migration forward.
|
|
||
| attributes.CategoryAttributesProfile, | ||
| attributes.CodeAttributesProfile, | ||
| attributes.CopyScopeProfile, |
There was a problem hiding this comment.
we can do the same for the copy scope profile?
| { // apply profiles as actions | ||
| APIGroups: []string{"actions.odigos.io"}, | ||
| Resources: []string{"k8sattributesresolvers"}, | ||
| Verbs: []string{"get", "list", "watch", "patch", "delete", "create"}, |
There was a problem hiding this comment.
why do we need all of these? the scheduler only does Apply, right?
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
|
This PR was closed because it has been stale for 30 days with no activity. |
2 participants
Description
This PR makes the following changes:
How Has This Been Tested?
Added profile, removed, checked all resources are created as needed
Kubernetes Checklist
User Facing Changes
No. only kratos users will see replicaset being collected automatically