Skip to content

Conversation

@blaggacao
Copy link

I think this was just overseen.

@xmo-odoo
Copy link
Collaborator

This is the wrong repository to submit pull requests to, submit to odoo/odoo

@blaggacao
Copy link
Author

sry.. the hermeneutic circle ;)

@xmo-odoo xmo-odoo closed this May 21, 2014
mart-e added a commit that referenced this pull request Aug 26, 2015
Small one letter terms are ignored when pushing the translations.
If these are included inside xml tags (e.g. <strong>#1</strong>, the term should
also be ignored.
Strip xml eventual tags when checking the length of a term.
kebeclibre added a commit that referenced this pull request Aug 1, 2019
Have an inherited view replacing a node in its parent
namely:

```
<view name="1">
  <world/>
  <world/>
  <world/>
</view>
```

Inherited by
```
<view name="2" inherit_id="1">
  <xpath expr="//world[1]" position="replace">
    <world/>
  </xpath>
</view>
```

Before this commit, the resulting xpath branding of the nodes
(useful for web_editor, to know where it is supposed to anchor new elements)
was incorrect. Note that there is the branding attr data-oe-view_id which specifies in which view they are

The 2nd and 3rd world in view #1 were numbered respectively world[1] and world[2]
which is incorrect since we *know* those should be world[2] and world[3]
(in their own view, i.e. in view #1)
This was because when replacing the node, the code lost track of what it replaced
and that it attributed the inheriting branding to the replacing nodes

After this commit, the 2nd and 3rd world nodes are numbered
world[2] and world[3] respectively

OPW 2007312
jva-odoo pushed a commit that referenced this pull request Aug 2, 2019
Have an inherited view replacing a node in its parent
namely:

```
<view name="1">
<world/>
<world/>
<world/>
</view>
```

Inherited by
```
<view name="2" inherit_id="1">
<xpath expr="//world[1]" position="replace">
<world/>
</xpath>
</view>
```

Before this commit, the resulting xpath branding of the nodes
(useful for web_editor, to know where it is supposed to anchor new elements)
was incorrect. Note that there is the branding attr data-oe-view_id which specifies in which view they are

The 2nd and 3rd world in view #1 were numbered respectively world[1] and world[2]
which is incorrect since we *know* those should be world[2] and world[3]
(in their own view, i.e. in view #1)
This was because when replacing the node, the code lost track of what it replaced
and that it attributed the inheriting branding to the replacing nodes

After this commit, the 2nd and 3rd world nodes are numbered
world[2] and world[3] respectively

OPW 2007312

closes odoo#35134

Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
adr-odoo pushed a commit that referenced this pull request Mar 25, 2020
Steps to reproduce:
1. Open sales on mobile
2. Click on the search icon (with breadcrumb)

    Issue #1:
    The displayed cross on the right suggests to users that it's
    used to close the facets but it's not.
    We replace it by a back arrow to close the search like in other
    apps.

3. Click on create 'Create'
4. Select a customer (Without breadcrumb)

   Issue #2:
   We don't have any breadcrumb inside the control_panel,
   so we should always display the search. There is no
   need to open/close it.

Task ID: 2200099
fw-bot pushed a commit that referenced this pull request Mar 25, 2020
Steps to reproduce:
1. Open sales on mobile
2. Click on the search icon (with breadcrumb)

    Issue #1:
    The displayed cross on the right suggests to users that it's
    used to close the facets but it's not.
    We replace it by a back arrow to close the search like in other
    apps.

3. Click on create 'Create'
4. Select a customer (Without breadcrumb)

   Issue #2:
   We don't have any breadcrumb inside the control_panel,
   so we should always display the search. There is no
   need to open/close it.

Task ID: 2200099

X-original-commit: a964780
tfr-odoo pushed a commit that referenced this pull request Mar 25, 2020
Steps to reproduce:
1. Open sales on mobile
2. Click on the search icon (with breadcrumb)

    Issue #1:
    The displayed cross on the right suggests to users that it's
    used to close the facets but it's not.
    We replace it by a back arrow to close the search like in other
    apps.

3. Click on create 'Create'
4. Select a customer (Without breadcrumb)

   Issue #2:
   We don't have any breadcrumb inside the control_panel,
   so we should always display the search. There is no
   need to open/close it.

Task ID: 2200099

closes odoo#46086

Related: odoo/enterprise#9486
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
fw-bot pushed a commit that referenced this pull request Mar 27, 2020
Steps to reproduce:
1. Open sales on mobile
2. Click on the search icon (with breadcrumb)

    Issue #1:
    The displayed cross on the right suggests to users that it's
    used to close the facets but it's not.
    We replace it by a back arrow to close the search like in other
    apps.

3. Click on create 'Create'
4. Select a customer (Without breadcrumb)

   Issue #2:
   We don't have any breadcrumb inside the control_panel,
   so we should always display the search. There is no
   need to open/close it.

Task ID: 2200099

closes odoo#48367

X-original-commit: a964780
Related: odoo/enterprise#9492
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
Signed-off-by: res-odoo <res-odoo@users.noreply.github.com>
duau-odoo added a commit that referenced this pull request Jun 5, 2025
This commit fixes an issue where modifying an image's shape would crash
if the image originated from a snippet that applied a shape by default.
The crash was due to a missing `originalSrc` attribute in the image's
dataset.

This bug was introduced by the website refactor [1], which removed
the `_initializeImage` method that was in `ImageTools`.
This method previously applied a regex to determine the correct URL
when `loadImageInfo` was called.

The fix reintroduces the necessary regex logic directly into the
`loadImageInfo` function. This logic now also accounts for `html_editor`
paths to ensure future compatibility when `image_shape` elements are
migrated from `web_editor`.

Steps to reproduce:
- Drop `s_mockup_image` snippet
- Click on the image
- Click to modify its shape from `MacBook #1` to another shape
- The operation should now work without traceback

[1]: odoo@9fe45e2

Related to task-4367641
fw-bot pushed a commit that referenced this pull request Jun 6, 2025
This commit fixes an issue where modifying an image's shape would crash
if the image originated from a snippet that applied a shape by default.
The crash was due to a missing `originalSrc` attribute in the image's
dataset.

This bug was introduced by the website refactor [1], which removed
the `_initializeImage` method that was in `ImageTools`.
This method previously applied a regex to determine the correct URL
when `loadImageInfo` was called.

The fix reintroduces the necessary regex logic directly into the
`loadImageInfo` function. This logic now also accounts for `html_editor`
paths to ensure future compatibility when `image_shape` elements are
migrated from `web_editor`.

Steps to reproduce:
- Drop `s_mockup_image` snippet
- Click on the image
- Click to modify its shape from `MacBook #1` to another shape
- The operation should now work without traceback

[1]: odoo@9fe45e2

Related to task-4367641

closes odoo#213018

Signed-off-by: Soukéina Bojabza (sobo) <sobo@odoo.com>
abyo-odoo added a commit that referenced this pull request Sep 12, 2025
Steps to reproduce Bug #1:
- Add Custom Lot/Serial to a product
- Create a manufactoring order with a quantity > 1
- Confirm and Generate Serial

Problem:
First SN is not prefilled by the Custom Lot/Serial added.

Steps to reproduce Bug #2:
- Create a duplicate from the previous MO
- Generate Serial Numbers

Problem:
First SN is not updated and generates serial numbers starting with "1"
again rather than incrementing the previous serial number.

Note: On adding new serial numbers different than the custom
(changing the prefilled First SN), it will only be applied
on that specfic MO only.
To apply it to any new MO, it must be added to the Custom Lot/Serial
field in the product form.
fw-bot pushed a commit that referenced this pull request Sep 12, 2025
Steps to reproduce Bug #1:
- Add Custom Lot/Serial to a product
- Create a manufactoring order with a quantity > 1
- Confirm and Generate Serial

Problem:
First SN is not prefilled by the Custom Lot/Serial added.

Steps to reproduce Bug #2:
- Create a duplicate from the previous MO
- Generate Serial Numbers

Problem:
First SN is not updated and generates serial numbers starting with "1"
again rather than incrementing the previous serial number.

Note: On adding new serial numbers different than the custom
(changing the prefilled First SN), it will only be applied
on that specfic MO only.
To apply it to any new MO, it must be added to the Custom Lot/Serial
field in the product form.

closes odoo#226046

Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Whenrow pushed a commit that referenced this pull request Sep 14, 2025
Steps to reproduce Bug #1:
- Add Custom Lot/Serial to a product
- Create a manufactoring order with a quantity > 1
- Confirm and Generate Serial

Problem:
First SN is not prefilled by the Custom Lot/Serial added.

Steps to reproduce Bug #2:
- Create a duplicate from the previous MO
- Generate Serial Numbers

Problem:
First SN is not updated and generates serial numbers starting with "1"
again rather than incrementing the previous serial number.

Note: On adding new serial numbers different than the custom
(changing the prefilled First SN), it will only be applied
on that specfic MO only.
To apply it to any new MO, it must be added to the Custom Lot/Serial
field in the product form.
abyo-odoo added a commit that referenced this pull request Sep 15, 2025
Steps to reproduce Bug #1:
- Add Custom Lot/Serial to a product
- Create a manufactoring order with a quantity > 1
- Confirm and Generate Serial

Problem:
First SN is not prefilled by the Custom Lot/Serial added.

Steps to reproduce Bug #2:
- Create a duplicate from the previous MO
- Generate Serial Numbers

Problem:
First SN is not updated and generates serial numbers starting with "1"
again rather than incrementing the previous serial number.

Note: On adding new serial numbers different than the custom
(changing the prefilled First SN), it will only be applied
on that specfic MO only.
To apply it to any new MO, it must be added to the Custom Lot/Serial
field in the product form.

closes odoo#227095

Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants