Anchor slide & scroll button #3477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-public-widgets, it needs to be retargeted before it can be merged. |
bso-odoo
force-pushed
the
master-public-widgets-bso-1
branch
2 times, most recently
from
8d02b0d to
2905058
Compare
ged-odoo
reviewed
Nov 6, 2024
ged-odoo
reviewed
Nov 6, 2024
There was a problem hiding this comment.
just to be sure, patchWithCleanup(window, { scrollTo() { ...} }); does not work?
There was a problem hiding this comment.
Nope, but it does not work with AnchorSlide either...
Edit: now relying on advanceTime
ged-odoo
reviewed
Nov 6, 2024
ged-odoo
reviewed
Nov 6, 2024
bso-odoo
force-pushed
the
master-public-widgets-bso-1
branch
from
2905058 to
4ea1189
Compare
|
This PR targets the un-managed branch odoo-dev/odoo:master-public-widgets, it needs to be retargeted before it can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.