add test, add waitForTimeout helper, small cleanup

addons/website/static/src/core/colibri.js

@@ -92,9 +92,11 @@ export class Colibri {
         for (let cleanup of this.cleanups.reverse()) {
             cleanup();
         }
+        this.cleanups = [];
         for (let [el, ev, fn, options] of this.handlers) {
             el.removeEventListener(ev, fn, options);
         }
+        this.handlers = [];
         this.classMap.clear();
         this.interaction.destroy();
         this.interaction.isDestroyed = true;

addons/website/static/src/core/interaction.js

@@ -38,6 +38,15 @@ export class Interaction {
         });
     }
 
+    waitForTimeout(fn, delay) {
+        setTimeout(() => {
+            if (!this.isDestroyed) {
+                fn();
+                this.updateDOM();
+            }
+        }, delay)
+    }
+
     updateDOM() {
         this.__colibri__.scheduleUpdate();
     }

addons/website/static/tests/core/website_core.test.js

@@ -29,3 +29,23 @@ test("wait for translation before starting interactions", async () => {
     await animationFrame();
     expect(started).toBe(true);
 });
+
+
+test("starting interactions twice should only actually do it once", async () => {
+    let n = 0;
+    class Test extends Interaction {
+        static selector = ".test";
+
+        setup() {
+            n++;
+        }
+    }
+
+    const { core } = await startInteraction(Test, `<div class="test"></div>`);
+
+    expect(n).toBe(1);
+    core.startInteractions();
+    await animationFrame();
+    expect(n).toBe(1);
+});
+