Skip to content

Conversation

@loco-odoo
Copy link

@loco-odoo loco-odoo commented Nov 20, 2024

Relaod iframe at save and implementation of the "discard" button.

@robodoo
Copy link

robodoo commented Nov 20, 2024

This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged.

@loco-odoo loco-odoo force-pushed the master-mysterious-egg-loco-1 branch 5 times, most recently from 135ea5e to a2e8017 Compare November 21, 2024 08:21
Comment on lines 79 to 89

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe patch onLoadIframe. To reduce the diff ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe have 2 utils, the basic for setup and another to edit ?

@loco-odoo loco-odoo force-pushed the master-mysterious-egg-loco-1 branch from a2e8017 to 869a064 Compare November 22, 2024 09:31
@loco-odoo loco-odoo force-pushed the master-mysterious-egg-loco-1 branch from 869a064 to 5edcee1 Compare November 22, 2024 09:43
@FrancoisGe FrancoisGe marked this pull request as ready for review November 22, 2024 10:19
@robodoo
Copy link

robodoo commented Nov 22, 2024

This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged.

@FrancoisGe FrancoisGe merged commit eb34fee into master-mysterious-egg Nov 22, 2024
@FrancoisGe FrancoisGe deleted the master-mysterious-egg-loco-1 branch November 22, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants