Skip to content

Conversation

@sobo-odoo
Copy link

No description provided.

@robodoo
Copy link

robodoo commented Jan 15, 2025

This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged.

@sobo-odoo sobo-odoo force-pushed the master-mysterious-egg-sobo-2 branch from 21a0353 to b2480c8 Compare January 15, 2025 18:07
@sobo-odoo sobo-odoo marked this pull request as ready for review January 15, 2025 18:16
@robodoo
Copy link

robodoo commented Jan 15, 2025

This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged.

context: this.context,
},
});
resolve();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add new customSnippet to snippetsByCategory.snippet_custom. It will trigger the reactivity. We probably not need to reload the page

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the end, I simply reloaded the snippets by calling load, because I still need to get the snippet html after the call (in order to be able to drop it afterwards), which is not easy to retrieve from the orm call
So the easiest was to just reload the snippets 🙂

@sobo-odoo sobo-odoo force-pushed the master-mysterious-egg-sobo-2 branch 3 times, most recently from c4f9a57 to ab088d7 Compare January 22, 2025 10:51
@sobo-odoo
Copy link
Author

I made the changes (see diff + other diff improving the rest of the of the test) 🙂

@sobo-odoo sobo-odoo force-pushed the master-mysterious-egg-sobo-2 branch from ab088d7 to 0cfd31b Compare January 22, 2025 13:30

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

t-on-pointerdown.stop="() => {}" (Why you need to do it ?)

Copy link
Author

@sobo-odoo sobo-odoo Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the sidebar or the container (don't remember which one) does something on pointerDown, which means that every time I clicked on the input, this click was canceled by this something, so I could not write in it
But I think this is temporary, when we will make the style,... of the sidebar correctly, maybe this could be removed ? I will see at that time 👍

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is because of prettier 🥲 I cannot add it back 😬

@sobo-odoo sobo-odoo force-pushed the master-mysterious-egg-sobo-2 branch from 0cfd31b to 935584f Compare January 23, 2025 17:31
@sobo-odoo
Copy link
Author

I made the changes (see diff) 🙂
I only clean for save the clone now (so I removed the savepoint) and so I fixed the clean_for_save_handlers in order to be consistent and to take into account the root element too (first commit) 🙂

@FrancoisGe FrancoisGe merged commit 0eb915c into master-mysterious-egg Jan 24, 2025
@FrancoisGe FrancoisGe deleted the master-mysterious-egg-sobo-2 branch January 24, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants