dynamic snippets options

[bso-odoo]

No description provided.

[robodoo]

This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged.

[ged-odoo]

be careful, the dynamicsnippetoption component is destroyed and recreated possibly many times (for ex, when switching from custom tab to block tab and back), so we don't want to refetch dynamic snippets everytime. i guess a better solution would be to move that in a plugin

[bso-odoo]

@ged-odoo As far as I undestood so far from the answers I received on this topic, there is no async life-cycle entry point in plugins, and their shared functions are not supposed to be async either... and if I keep the info in a Promise in the plugin, I doubt the template rendering allows await.

[ged-odoo]

in a plugin, you don't have to have a async lifecycle. you can just work with promises:

class DynamicSnippetOptionPlugin extends Plugin {
    static id = "DynamicSnippetOption";
    resources = {
        builder_options: [
            withSequence(10, {
                OptionComponent: DynamicSnippetOption,
                props: { loadFilters: () => this.fetchDynamicFilters() },
                selector: ".s_dynamic_snippet",
            }),
        ],
        builder_actions: this.getActions(),
    };

  setup() {
    this.filters = null;
  }
  fetchDynamicFilters() {
    if (!this.filters) {
      this.filters = this._fetchDynamicFilters();
    }
    return this.filters;
  }
  async _fetchDynamicFilters() {
    const filters = await rpc(...);
     ....
  }
}

and in your component:

class DynamicSnippetOption extends Component {
  onWillStart() {
    this.filters = await this.props.loadFilters();
  }

[bso-odoo]

Ok, I did something similar, but with a cache based on the parameters since the plugin is a singleton. And I also made those shared methods so that the other kinds of dynamic snippet options can also use them.

[robodoo]

This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged.

[FrancoisGe]

if (unit) {
if(saveUnit) {
actionValue = convertNumericToUnit(...) + saveUnit
} else {
actionValue = actionValue + unit
}

[bso-odoo]

Also added test

[FrancoisGe]

you don t use template_opt ?

[bso-odoo]

Used by future xpaths

[FrancoisGe]

you don t use filter_opt ?

[bso-odoo]

Used by future xpaths

[FrancoisGe]

<BuilderSelectItem t-if=""template.thumb" is supported if you want to remove 2 lines

[bso-odoo]

I prefer to be able to xpath "inside t-if" in case the image is not just what we want