Skip to content

Conversation

@bso-odoo
Copy link

No description provided.

@robodoo
Copy link

robodoo commented Feb 11, 2025

This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged.

@bso-odoo bso-odoo force-pushed the master-mysterious-egg-bso-2 branch 3 times, most recently from b6d7f1e to 1273834 Compare February 12, 2025 12:53
@bso-odoo bso-odoo marked this pull request as ready for review February 12, 2025 13:01
@robodoo
Copy link

robodoo commented Feb 12, 2025

This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged.

Comment on lines 37 to 38

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because input is hide at the begining I think

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to its own component

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recTuples => records ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed to tuples. The name records will be used below in that function in an incoming version

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe check if props change ? (Or use a Cache ?)

@bso-odoo bso-odoo force-pushed the master-mysterious-egg-bso-2 branch from 1273834 to 30bc887 Compare February 13, 2025 09:03
@bso-odoo bso-odoo force-pushed the master-mysterious-egg-bso-2 branch from 30bc887 to 1d1b035 Compare February 13, 2025 10:08
@bso-odoo bso-odoo force-pushed the master-mysterious-egg-bso-2 branch from 1d1b035 to 6a07d82 Compare February 13, 2025 10:12
@FrancoisGe FrancoisGe merged commit dd21b5e into master-mysterious-egg Feb 13, 2025
@FrancoisGe FrancoisGe deleted the master-mysterious-egg-bso-2 branch February 13, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants