Prevent to get or set an attribute on a recordset if it holds more than one attributes

openerp/addons/base/res/res_currency.py

@@ -116,7 +116,7 @@ def init(self, cr):
     @api.one
     @api.depends('rate_ids.name')
     def compute_date(self):
-        self.date = self.rate_ids.name
+        self.date = self.rate_ids[0].name if self.rate_ids else False
 
     def name_search(self, cr, user, name='', args=None, operator='ilike', context=None, limit=100):
         if not args:

openerp/addons/test_new_api/tests/test_new_fields.py

@@ -5,7 +5,7 @@
 from collections import defaultdict
 
 from openerp.tests import common
-
+from openerp.exceptions import Warning
 
 class TestNewFields(common.TransactionCase):
 
@@ -23,6 +23,26 @@ def test_00_basics(self):
         values = discussion.read(['name'])[0]
         self.assertEqual(values['name'], discussion.name)
 
+    def test_01_basic_set_assertion(self):
+        """ test item setter """
+        record = self.env.ref('test_new_api.message_0_0')
+        self.assertEqual(len(record), 1)
+        record.body = 'OK'
+        records = self.env['test_new_api.message'].search([])
+        assert len(records) > 1
+        with self.assertRaises(Warning):
+            records.body = 'Faulty'
+
+    def test_01_basic_get_assertion(self):
+        """ test item getter """
+        record = self.env.ref('test_new_api.message_0_0')
+        self.assertEqual(len(record), 1)
+        ok = record.body
+        records = self.env['test_new_api.message'].search([])
+        assert len(records) > 1
+        with self.assertRaises(Warning):
+            faulty = records.body
+
     def test_10_computed(self):
         """ check definition of computed fields """
         # by default function fields are not stored and readonly

openerp/osv/fields2.py

@@ -430,7 +430,8 @@ def __get__(self, record, owner):
         """ return the value of field `self` on `record` """
         if record is None:
             return self         # the field is accessed through the owner class
-
+        if len(record) > 1:
+            raise Warning("Multiple records properties %s may not be accessed" % record)
         try:
             return record._cache[self]
         except KeyError:
@@ -453,8 +454,9 @@ def __get__(self, record, owner):
     def __set__(self, record, value):
         """ set the value of field `self` on `record` """
         if not record:
-            raise Warning("Null record %s may not be assigned" % record)
-
+            raise Warning('Null record %s may not be assigned' % record)
+        if len(record) > 1:
+            raise Warning('Multiple records %s may not be assigned' % record)
         # only one record is updated
         env = record.env
         record = record[0]
@@ -713,7 +715,7 @@ def context_today(record, timestamp=None):
             :param datetime timestamp: optional datetime value to use instead of
                 the current date and time (must be a datetime, regular dates
                 can't be converted between timezones.)
-            :rtype: str 
+            :rtype: str
         """
         today = timestamp or datetime.now()
         context_today = None