[FIX] various improvements to test execution and rest connector#140
Merged
Conversation
sea-odoo
force-pushed
the
fix/various-improvements-beta
branch
from
0103d2d to
9da71d0
Compare
brinkflew
reviewed
Apr 1, 2026
brinkflew
previously approved these changes
Apr 3, 2026
- Use readlink -f in odev.sh for better script resolution - Refactor database template creation logic - Relax database name validation to allow colons - Include request body in RestConnector cache key - Fix odev.plugins module initialization for Python 3 compatibility - Deduplicate addons paths - Proper shell quoting for python script arguments
- Fixed carriage return handling in shell stream to avoid broken log formatting. - Enhanced ODOO_LOG_REGEX to support logs without date or PID. - Standardized version, venv, and worktree resolution to look for *_argument attributes in commands. - Added combined_odoo_args to handle Odoo flags captured by positional 'addons' argument. - Implemented --command flag support for 'odev shell' to pipe code via stdin.
- Added EmployeeUtils to centralize Odoo employee detection and xgram retrieval. - Updated Telemetry to use the new utility.
Implemented native 'upgrade_code' tool support. The command includes logic to automatically handle shell glob expansion and reconstruct target glob patterns for the Odoo upgrade tool.
brinkflew
requested changes
Apr 9, 2026
Comment on lines
+67
to
+77
| # Redeclare database to ensure its order is correct | ||
| database_arg = args.String( | ||
| name="database", | ||
| description="The database to target (used for version/path resolution).", | ||
| ) | ||
|
|
||
| # Catch-all for extra arguments | ||
| odoo_args = args.String( | ||
| nargs="*", | ||
| description="Additional arguments to pass to odoo-bin.", | ||
| ) |
Contributor
There was a problem hiding this comment.
Isn't this already inherited from OdoobinCommand?
Contributor
There was a problem hiding this comment.
This could have been its own PR haha
| secret = self.odev.store.secrets.get("accounts.odoo.com", ["login"], scope="user", ask_missing=False) | ||
| if secret and secret.login.endswith("@odoo.com"): | ||
| return secret.login.split("@")[0] | ||
| except Exception: # noqa: BLE001, S110 |
Contributor
There was a problem hiding this comment.
Don't use blind exceptions
| email = process.stdout.decode().strip() | ||
| if email.endswith("@odoo.com"): | ||
| return email.split("@")[0] | ||
| except Exception: # noqa: BLE001, S110 |
sea-odoo
added a commit
that referenced
this pull request
Apr 25, 2026
* [FIX] various improvements to test execution and rest connector * core: miscellaneous improvements and bug fixes - Use readlink -f in odev.sh for better script resolution - Refactor database template creation logic - Relax database name validation to allow colons - Include request body in RestConnector cache key - Fix odev.plugins module initialization for Python 3 compatibility - Deduplicate addons paths - Proper shell quoting for python script arguments * [FIX] Version bump * [IMP] core: improve odoo log parsing and argument handling - Fixed carriage return handling in shell stream to avoid broken log formatting. - Enhanced ODOO_LOG_REGEX to support logs without date or PID. - Standardized version, venv, and worktree resolution to look for *_argument attributes in commands. - Added combined_odoo_args to handle Odoo flags captured by positional 'addons' argument. - Implemented --command flag support for 'odev shell' to pipe code via stdin. * [IMP] core: introduce EmployeeUtils and refactor telemetry - Added EmployeeUtils to centralize Odoo employee detection and xgram retrieval. - Updated Telemetry to use the new utility. * [IMP] core: add upgrade-code command for Odoo 18.0+ Implemented native 'upgrade_code' tool support. The command includes logic to automatically handle shell glob expansion and reconstruct target glob patterns for the Odoo upgrade tool. * [FIX] Fix after review * [FIX] Fix failing test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes improvements to Odoo test execution error handling, simplified subcommand input formatting, and forced authentication in RestConnector downloads.