[IMP] domain_names: CAA record - #19308
Closed
mege-odoo wants to merge 1 commit into
Closed
Conversation
Collaborator
|
|
auva-odoo
approved these changes
Aug 6, 2026
auva-odoo
left a comment
auva-odoo
left a comment
Contributor
There was a problem hiding this comment.
Thank you @mege-odoo, my suggestion for improvement is pretty minor so I'll go ahead and approve this already. Thanks!
@robodoo delegate+
Comment on lines
+365
to
+367
| <https://letsencrypt.org/how-it-works/>`_. If you have a CAA record configured for your domain, make sure it `allows | ||
| Let's Encrypt <https://letsencrypt.org/docs/caa/>`_, otherwise the certificate can fail to | ||
| generate. |
Contributor
There was a problem hiding this comment.
Suggested change
| <https://letsencrypt.org/how-it-works/>`_. If you have a CAA record configured for your domain, make sure it `allows | |
| Let's Encrypt <https://letsencrypt.org/docs/caa/>`_, otherwise the certificate can fail to | |
| generate. | |
| <https://letsencrypt.org/how-it-works/>`_. Any CAA record configured for the domain must | |
| `allow Let's Encrypt <https://letsencrypt.org/docs/caa/>`_, otherwise certificate generation | |
| may fail. |
to avoid the overuse of you as per the doc guidelines and be a bit more direct in the process 🙂
Contributor
Author
There was a problem hiding this comment.
Thanks for tightening that up and the style tip! :-)
It also made me realize the original and commit description were inaccurate in the sense that it's not a singular CAA record or each individual CAA record that needs to be updated. If a domain has one or more CAA records, the user needs to add additional CAA records to allow Let's Encrypt, or remove the restrictive ones. So I kept your wording, but made "CAA records" plural.
Occasionally customers use one or more CAA records to restrict which certificate authorities are allowed to provide certificates for their domain. If Let's Encrypt is not included in that, it will cause the certificate generation by Odoo Online or SH to fail. Since this is an advanced topic, I opted to put a note about it in the section that gives more details about the SSL implementation. I expect that putting it in the main "Configure an existing domain name" section would cause confusion for most customers.
mege-odoo
force-pushed
the
17.0-caa-record-ssl-impact-mege
branch
from
August 6, 2026 12:33
fd500d2 to
8eb08c7
Compare
Contributor
Author
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Aug 6, 2026
Occasionally customers use one or more CAA records to restrict which certificate authorities are allowed to provide certificates for their domain. If Let's Encrypt is not included in that, it will cause the certificate generation by Odoo Online or SH to fail. Since this is an advanced topic, I opted to put a note about it in the section that gives more details about the SSL implementation. I expect that putting it in the main "Configure an existing domain name" section would cause confusion for most customers. closes #19308 Signed-off-by: Merel Geens <mege@odoo.com>
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Occasionally customers use a CAA record to restrict which certificate authorities are allowed to provide certificates for their domain. If Let's Encrypt is not included in that, it will cause the certificate generation by Odoo Online or SH to fail.
Since this is an advanced topic, I opted to put a note about it in the section that gives more details about the SSL implementation. I expect that putting it in the main "Configure an existing domain name" section would cause confusion for most customers.