[ADD] discuss: specific email server from #2627

samueljlieber · 2022-08-24T14:33:59Z

Manual cherry pick of #2626 which is a follow up from #1449.

Odoo 15.0 introduced the ability to use a specific email server depending on the "From". So a new section "Set up different outgoing servers in a multi-company environment" has been added in the documentation. This explains the logic applied to select the right email server.

robodoo · 2022-08-24T14:34:31Z

Pull request status dashboard.

StraubCreative · 2022-08-24T17:24:30Z

@cth-odoo @tiku-odoo @std-odoo @AntoineVDV
Let's continue content and technical review here for this PR.

@samueljlieber took all of the change requests from the prior PR (#1449) and moved them over to this new feature branch. Now we have a clean commit history and no more technical hiccups.

Please take a look at what we have here, and let Sam know if any changes are needed in the content and he will take care of making those updates. Afterwards we can ship to final reviews.

Thank you 🙏

tiku-odoo · 2022-08-26T13:33:07Z

@Abridbus @std-odoo When you have a moment can you review this change? We will be documenting the from_filter in as well: #2055

We are open to suggestions. Thanks, Tim

@StraubCreative Although this PR is for V15 only, this document is being updated in PR #2075 (V13-V15)

content/applications/productivity/discuss/advanced.rst

content/applications/productivity/discuss/advanced/email_servers.rst

tiku-odoo

@samueljlieber Here is a draft of the changes to be made per @std-odoo

Thanks

content/applications/productivity/discuss/advanced/email_servers.rst

samueljlieber · 2022-09-07T14:23:40Z

Hi @tiku-odoo and @std-odoo!

Thanks for the suggestions! I made the content change and I updated the commit message tag to use all uppercase.

tiku-odoo

@samueljlieber Looks great! Tagging @mivu-odoo for final review.

mivu-odoo

Hi @samueljlieber and @tiku-odoo! Thanks for your patience on this!

As I was going through this file, I noticed things were sounding very familiar. Is it the same content as PR #2075? If it is the same content, with no changes, it might be easier to finish PR #2075 first and get that approved, merged, and forward-ported. Then, we can simply copy the content onto this PR.

If there are slight changes, please let me know and I can finish my review, while trying to keep the content of the email_servers.rst file from this PR as close to the email_servers.rst file from PR #2075.

StraubCreative · 2022-09-16T17:30:37Z

Then, we can simply copy the content onto this PR.

while trying to keep the content of the email_servers.rst file from this PR as close to the email_servers.rst file from PR #2075.

If both PRs are editing the same content in the same file, then we will likely run into a merge conflict during rebase.

Normally, the merge conflict is solved by picking the the changes from w/e commit has the correct content, as in, there shouldn't be a need to manually make sure the versions match.

However, given that there are considerable differences between the two versions, either @samueljlieber or I would need guidance as to where the last PR ends and where the new one begins. It sounds like @mivu-odoo is asking for the same thing as to avoid reviewing content that would become obsolete with the forward-port from #2075 .

I agree to let #2075 get merged first-- afterwards, let's see if a merge conflict shows up. If it does, then let's jump on a a screenshare @samueljlieber @tiku-odoo and go through the merge conflict together so we can set this up right for @mivu-odoo 's review.

StraubCreative · 2022-09-28T17:51:48Z

Update:

We're just waiting for the forward-port PRs to finish up on #2075. Had to solve a merge conflict on one of them which affected a few others, but they should be on track again.

After those are done we can rebase those changes into this PR and @tiku-odoo / @std-odoo we'll need your help picking what changes we should keep for the final version of the file.

cc: @mivu-odoo @samueljlieber

tiku-odoo · 2022-10-04T20:30:50Z

@StraubCreative / @samueljlieber --

It looks like all the forward ports for PR #2075 have been closed out.

The material in this PR should be placed before the section on 'Set up different dedicated servers for transactional and mass mails'.

For this change we will be adding Lines 217 --> 247 in the files changes doc on this PR:

Setting up different outgoing email servers for a multi-company environment

The "From Filter" allows for the use of a specific outgoing email server depending on the "From"
email address that Odoo is sending on behalf of. When an email is sent from Odoo and the "From
Filter" is configured, then the email server will be chosen as follows:

#. Odoo searches for an email server having the same "From Filter" as the "From" email address
defined in the outgoing email. For example, if the "From" email address is test@example.com,
only the email servers having the "From Filter" equal to test@example.com will be returned.

#. If no email servers are found, then Odoo searches for an email server having the same domain in
the "From Filter" as in the "From" email address of the outgoing email. For example, if the
"From" email address is test@example.com, only the email servers having the "From Filter" equal
to example.com will be returned.

If no email servers are found after checking for the domain, then Odoo will return all email
servers without any "From Filter" set.

Should this previous query return no results, then Odoo performs a search for an email server
using the system parameter: 'mail.default.from'. First, the email address listed will attempt
to match an email server and then the domain will attempt a match.

If no email server is found then Odoo will return the first outgoing email server (sorted by
priority). In this case, it is likely the email configuration will be spoofing the email and it
will be flagged as Spam.

.. note::
If several email servers are found, then Odoo will use the first one according to its priority.
For example, if there are two email servers, one with a priority of 10 and the other with a
priority of 20, then the email server with a priority of 10 will be used.

samueljlieber · 2022-11-01T20:57:29Z

Commit af46e00 to correct changes email_servers.rst.

In this PR #2627, changes were initially made to .../discuss/advanced/email_servers.rst when they should have been made to .../general/email_communication/email_servers.rst.

mivu-odoo

Hi @samueljlieber and @tiku-odoo!

I made a couple of comments on formatting and small word changes. Once you integrate those, please tag me again and I'll approve this PR so it can move onto ZST for final technical review. Thank you 😸

content/applications/general/email_communication/email_servers.rst

tiku-odoo · 2022-11-03T15:38:44Z

@mivu-odoo This document has been updated with your changes. Can you review the doc once more? Thanks in advance for your help on this doc :)

mivu-odoo

Hi @samueljlieber and @tiku-odoo!

Thank you for making the edits! I found one more quick edit on Line 211 (changing the single quotation marks to backticks). Once you push that through, feel free to go straight to ZST for final technical review, no need to tag me again.

Thank you 😸

content/applications/general/email_communication/email_servers.rst

StraubCreative

Hi @tiku-odoo 👋

I have a few suggestions below, which mainly involve GUI elements, context, and word choices. They are as follows:

add :guilabel:'s to GUI elements, since we are directly referring to them AND entertaining interactions with them.
add navigational steps to provide location-based context to the user; the documentation is not helpful if the user doesn't know where they're supposed to be 😉
some word choices here and there to improve flow/clarity.
one instance of an early line break

For future PRs, here are a few improvements I'd recommend to bring up the quality of the whole doc 🚀

clean up and streamline the RST formatting to the latest markup standards.
Use less passive/past tense in favor of more active/present tense, per Content Guidelines.

cc: @mivu-odoo @samueljlieber

content/applications/general/email_communication/email_servers.rst

tiku-odoo · 2022-11-09T16:39:49Z

@mivu-odoo When you have a moment can you review this doc again? Thanks in advance for your review. 👍

mivu-odoo

Hi @tiku-odoo!

I made some comments/suggestions, mainly targeted towards clarity. I also think some parts can benefit from a sample use case to help the reader understand why they might need to use the feature.

When you're ready, tag me again for another look 😸 Thank you!

mivu-odoo · 2022-11-09T23:18:00Z

content/applications/general/email_communication/email_servers.rst

+=======================================================================
+
+The :guilabel:`FROM Filtering` field allows for the use of a specific outgoing email server
+depending on the :guilabel:`From` email address that Odoo is sending on behalf of. Access this


After the first sentence (The...on behalf of), I would add a real-life example (1-3 sentences) of why a company might want to use this feature. The section header says it's for multi-company environments. Try to simplify for the reader and help them visualize how they would apply this section's knowledge to their business.

@mivu-odoo I've added two separate sentences: 1. to improve deliverability 2. In a multi-company environment

The title seemed a bit too specific and I've made it more general as multi-company sending is not the only application. I've changed it to: Utilizing the FROM Filter on an outgoing email server

content/applications/general/email_communication/email_servers.rst

mivu-odoo · 2022-11-09T23:33:12Z

content/applications/general/email_communication/email_servers.rst

+If no email servers are found after checking for the domain, then Odoo will return all email
+servers that do not have any :guilabel:`FROM Filtering` value(s) set.
+
+Should this previous query return no results, then Odoo performs a search for an email server using


Clarify this previous query - which one are we talking about?

This sentence refers to the sentence in the previous line. I've removed the word previously.

content/applications/general/email_communication/email_servers.rst

tiku-odoo · 2022-11-10T18:23:29Z

@mivu-odoo This PR is ready for another review from you when you have a chance. Thanks in advance for your help on this From Filter PR.

mivu-odoo

Hi @tiku-odoo!

Thank you for addressing my comments! The first paragraph of the Utilizing the From Filter on on outgoing email server section is easier to understand now.

Please move forward to final technical review and tag ZST. Thank you 😸

tiku-odoo · 2022-11-10T21:26:20Z

Thanks @mivu-odoo

@StraubCreative This doc is ready for your technical review whenever you have a moment. Thanks in advance for your help on this PR. 👍

StraubCreative

Edited a line break + fresh rebase in ed0ed06 but otherwise LGTM 👍

Note/reminder to create a card to do entire doc update since a lot of the RST formatting seems out of date @tiku-odoo @samueljlieber . Content could always use another look too just in case ;)

Tagging in @odoo/doc-review

AntoineVDV

@robodoo r+

closes #2627 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>

fw-bot · 2022-11-25T05:53:23Z

@samueljlieber @AntoineVDV this pull request has forward-port PRs awaiting action (not merged or closed):
#2990

fw-bot · 2022-11-26T05:54:26Z

@samueljlieber @AntoineVDV this pull request has forward-port PRs awaiting action (not merged or closed):
#2990

fw-bot · 2022-11-27T05:54:00Z

@samueljlieber @AntoineVDV this pull request has forward-port PRs awaiting action (not merged or closed):
#2990

fw-bot · 2022-11-28T05:53:59Z

@samueljlieber @AntoineVDV this pull request has forward-port PRs awaiting action (not merged or closed):
#2990

fw-bot · 2022-11-29T05:53:29Z

@samueljlieber @AntoineVDV this pull request has forward-port PRs awaiting action (not merged or closed):
#2990

fw-bot · 2022-11-30T05:53:16Z

@samueljlieber @AntoineVDV this pull request has forward-port PRs awaiting action (not merged or closed):
#2990

samueljlieber mentioned this pull request Aug 24, 2022

Cth odoo filter from #2626

Closed

C3POdoo requested a review from a team August 24, 2022 14:35

samueljlieber assigned samueljlieber and StraubCreative Aug 24, 2022

samueljlieber requested a review from tiku-odoo August 24, 2022 15:03

tiku-odoo requested a review from std-odoo September 6, 2022 19:56

std-odoo reviewed Sep 7, 2022

View reviewed changes

samueljlieber added OE Linked to a support ticket and removed OE Linked to a support ticket labels Sep 7, 2022

tiku-odoo suggested changes Sep 7, 2022

View reviewed changes

content/applications/productivity/discuss/advanced/email_servers.rst Outdated Show resolved Hide resolved

samueljlieber force-pushed the 15.0-email-server-from-cth branch from b855871 to 9930359 Compare September 7, 2022 14:19

tiku-odoo approved these changes Sep 7, 2022

View reviewed changes

tiku-odoo requested a review from mivu-odoo September 7, 2022 15:21

mivu-odoo reviewed Sep 16, 2022

View reviewed changes

samueljlieber force-pushed the 15.0-email-server-from-cth branch from 9930359 to e8a7283 Compare November 1, 2022 20:31

StraubCreative requested a review from mivu-odoo November 1, 2022 20:31

C3POdoo requested a review from a team November 1, 2022 20:52

samueljlieber force-pushed the 15.0-email-server-from-cth branch from 9a26c86 to af46e00 Compare November 1, 2022 20:52

mivu-odoo suggested changes Nov 2, 2022

View reviewed changes

tiku-odoo force-pushed the 15.0-email-server-from-cth branch from af46e00 to d2b951f Compare November 3, 2022 15:35

mivu-odoo approved these changes Nov 3, 2022

View reviewed changes

content/applications/general/email_communication/email_servers.rst Outdated Show resolved Hide resolved

samueljlieber requested a review from StraubCreative November 4, 2022 19:05

StraubCreative requested changes Nov 8, 2022

View reviewed changes

tiku-odoo force-pushed the 15.0-email-server-from-cth branch 2 times, most recently from 0422c98 to 65aef56 Compare November 9, 2022 16:30

mivu-odoo suggested changes Nov 9, 2022

View reviewed changes

tiku-odoo force-pushed the 15.0-email-server-from-cth branch from 65aef56 to 975643a Compare November 10, 2022 18:06

mivu-odoo approved these changes Nov 10, 2022

View reviewed changes

tiku-odoo requested a review from StraubCreative November 10, 2022 21:26

[ADD] discuss: specific email server from

ed0ed06

StraubCreative force-pushed the 15.0-email-server-from-cth branch from 975643a to ed0ed06 Compare November 18, 2022 22:26

StraubCreative approved these changes Nov 18, 2022

View reviewed changes

StraubCreative requested a review from a team November 18, 2022 22:30

AntoineVDV approved these changes Nov 21, 2022

View reviewed changes

robodoo pushed a commit that referenced this pull request Nov 21, 2022

[ADD] discuss: specific email server from

ce1d0b2

closes #2627 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>

robodoo temporarily deployed to merge November 21, 2022 09:44 Inactive

robodoo closed this Nov 21, 2022

This was referenced Nov 21, 2022

[FW][add] discuss: specific email server from #2990

Closed

[FW][add] discuss: specific email server from #2991

Closed

[FW][add] discuss: specific email server from #2992

Closed

[FW][add] discuss: specific email server from #2993

Closed

samueljlieber changed the title ~~[add] discuss: specific email server from~~ [ADD] discuss: specific email server from Apr 23, 2025

[ADD] discuss: specific email server from #2627

[ADD] discuss: specific email server from #2627

Uh oh!

Conversation

samueljlieber commented Aug 24, 2022

Uh oh!

robodoo commented Aug 24, 2022

Uh oh!

StraubCreative commented Aug 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tiku-odoo commented Aug 26, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tiku-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

samueljlieber commented Sep 7, 2022

Uh oh!

tiku-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

mivu-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

StraubCreative commented Sep 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

StraubCreative commented Sep 28, 2022

Uh oh!

tiku-odoo commented Oct 4, 2022

Setting up different outgoing email servers for a multi-company environment

Uh oh!

samueljlieber commented Nov 1, 2022

Uh oh!

mivu-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tiku-odoo commented Nov 3, 2022

Uh oh!

mivu-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

StraubCreative left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tiku-odoo commented Nov 9, 2022

Uh oh!

mivu-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

mivu-odoo Nov 9, 2022

Choose a reason for hiding this comment

Uh oh!

tiku-odoo Nov 10, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mivu-odoo Nov 9, 2022

Choose a reason for hiding this comment

Uh oh!

tiku-odoo Nov 10, 2022

Choose a reason for hiding this comment

StraubCreative commented Aug 24, 2022 •

edited

Loading

StraubCreative commented Sep 16, 2022 •

edited

Loading