-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Add mail.default.from_filter in mail documentation #2055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tiku-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Jonathan @jqu-odoo -- I just made a small change to get rid of the familiar second person. Can you edit the RST? Thanks :)
|
|
||
| To force the email address from which emails are sent, you need to create the following key in | ||
| the System Parameters of the database: | ||
| To force the email address from which emails are sent, you need to use a combination of the following keys in the system parameters of the database: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To force the email address from which emails are sent, a combination of the following keys needs to be set in the system parameters of the database:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tiku-odoo The whole file is in the second person so I wouldn't change that sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jqu-odoo Thanks for the suggestion, the content team generally tries to keep things consistent by not writing in the 2nd person. I realize there are a few sentences where this isn't the case in our current documentation. We are working to get those edits made and the grammar corrected. In this situation I'd like to make this small change.
content/applications/general/email_communication/email_domain.rst
Outdated
Show resolved
Hide resolved
tiku-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@std-odoo The mail.default.from_filter isn't explained in any documentation that I'm aware of. Does the match mail.default.from_filter system parameter apply to V14 V13?
@jqu-odoo We probably should update this document as well: applications/general/email_communication/email_servers.html#use-a-default-from-email-address
content/applications/general/email_communication/email_domain.rst
Outdated
Show resolved
Hide resolved
Only for v15 :) |
|
Hi Jonathan, Thank you for updating the RST:) Let's leave the bit on the catchall out, I agree with you on this. Thanks for correcting the part on the mail.default.from_filter being empty. I think this change is ready for doc-review team. What do you think? Thank you for all your help on this :) Tim |
bda05fa to
d81fee8
Compare
|
Hi @tiku-odoo and @Abridbus I cleaned up the commits and updated the RST for this PR. I see there are requested reviews for @Abridbus and @weka-odoo , can we get an approval/revisions update on the content? Thank you! 🙂 |
d81fee8 to
4b7f0a8
Compare
| be set in the system parameters of the database: | ||
|
|
||
| - `mail.default.from`: accepts the local part or a complete email address as value | ||
| - `mail.default.from_filter`: accepts a domain name or a full email address as value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mail.default.from_filter is only if you use the odoo-bin config, otherwise it's the from_filter field on ir.mail_server, not sure if it should me mentioned here
| the domain be listed then all emails with that domain will be preserved; and if a full email | ||
| address is listed then all emails will be replaced by the given address. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and if a full email address is listed then all emails will be replaced by the given address.
That's not 100% true, we never use the from_filter to replace the email (only the system parameters mail.default.from / mail.catchall.domain
This sentence is a bit confusing imo
It should be something like
if the from_filter contains a full email address, and if the
mail.default.fromis the same as this address, then all email different thanmail.default.fromwill be encapsulated inmail.default.from
4b7f0a8 to
c3fe86f
Compare
|
There's a significant issue with this branch-- for whatever reason it's not bringing in the updates from it's parent commit at 1168ba and is therefore producing build errors. So there's a new new cherry-pick of this PR, with a clean commit history, available over at #2694. I applied the content change requests from the last review, so it should be good for another review. For all further change requests on the new PR, please ask @samueljlieber to perform them for you. Thanks and kind regards :) |
The mail.default.from_filter ICP was introduced by odoo/odoo#80943 and is set by default on all new cloud databases.
The documentation for Odoo default SMTP users needs to be adapted.