Skip to content

Conversation

@jqu-odoo
Copy link
Contributor

The mail.default.from_filter ICP was introduced by odoo/odoo#80943 and is set by default on all new cloud databases.

The documentation for Odoo default SMTP users needs to be adapted.

@robodoo
Copy link
Collaborator

robodoo commented May 20, 2022

@jqu-odoo jqu-odoo requested a review from Abridbus May 20, 2022 07:21
Copy link
Contributor

@tiku-odoo tiku-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jonathan @jqu-odoo -- I just made a small change to get rid of the familiar second person. Can you edit the RST? Thanks :)


To force the email address from which emails are sent, you need to create the following key in
the System Parameters of the database:
To force the email address from which emails are sent, you need to use a combination of the following keys in the system parameters of the database:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To force the email address from which emails are sent, a combination of the following keys needs to be set in the system parameters of the database:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tiku-odoo The whole file is in the second person so I wouldn't change that sentence.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jqu-odoo Thanks for the suggestion, the content team generally tries to keep things consistent by not writing in the 2nd person. I realize there are a few sentences where this isn't the case in our current documentation. We are working to get those edits made and the grammar corrected. In this situation I'd like to make this small change.

Copy link
Contributor

@tiku-odoo tiku-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@std-odoo The mail.default.from_filter isn't explained in any documentation that I'm aware of. Does the match mail.default.from_filter system parameter apply to V14 V13?

@jqu-odoo We probably should update this document as well: applications/general/email_communication/email_servers.html#use-a-default-from-email-address

@std-odoo
Copy link
Contributor

std-odoo commented Jun 1, 2022

@std-odoo The mail.default.from_filter isn't explained in any documentation that I'm aware of. Does the match mail.default.from_filter system parameter apply to V14 V13?

Only for v15 :)

@tiku-odoo tiku-odoo requested a review from weka-one June 9, 2022 18:08
@tiku-odoo
Copy link
Contributor

tiku-odoo commented Jun 16, 2022

Hi Jonathan,

@jqu-odoo

Thank you for updating the RST:)

Let's leave the bit on the catchall out, I agree with you on this.

Thanks for correcting the part on the mail.default.from_filter being empty.

I think this change is ready for doc-review team. What do you think?

Thank you for all your help on this :)

Tim

@samueljlieber samueljlieber force-pushed the jqu-odoo-doc-1 branch 2 times, most recently from bda05fa to d81fee8 Compare August 24, 2022 16:29
@samueljlieber
Copy link
Contributor

samueljlieber commented Aug 25, 2022

Hi @tiku-odoo and @Abridbus

I cleaned up the commits and updated the RST for this PR. I see there are requested reviews for @Abridbus and @weka-odoo , can we get an approval/revisions update on the content?

Thank you! 🙂

@tiku-odoo tiku-odoo removed the request for review from weka-one August 31, 2022 13:27
@tiku-odoo tiku-odoo removed the request for review from Abridbus September 6, 2022 19:55
be set in the system parameters of the database:

- `mail.default.from`: accepts the local part or a complete email address as value
- `mail.default.from_filter`: accepts a domain name or a full email address as value
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mail.default.from_filter is only if you use the odoo-bin config, otherwise it's the from_filter field on ir.mail_server, not sure if it should me mentioned here

Comment on lines +170 to +171
the domain be listed then all emails with that domain will be preserved; and if a full email
address is listed then all emails will be replaced by the given address.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and if a full email address is listed then all emails will be replaced by the given address.

That's not 100% true, we never use the from_filter to replace the email (only the system parameters mail.default.from / mail.catchall.domain

This sentence is a bit confusing imo

It should be something like

if the from_filter contains a full email address, and if the mail.default.from is the same as this address, then all email different than mail.default.from will be encapsulated in mail.default.from

@StraubCreative
Copy link
Contributor

@std-odoo @tiku-odoo

There's a significant issue with this branch-- for whatever reason it's not bringing in the updates from it's parent commit at 1168ba and is therefore producing build errors.

So there's a new new cherry-pick of this PR, with a clean commit history, available over at #2694.
Please continue your work there :)

I applied the content change requests from the last review, so it should be good for another review.

For all further change requests on the new PR, please ask @samueljlieber to perform them for you.
Closing this one.

Thanks and kind regards :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants