16.0 upgrade doc condensing nama

[nmarotte]

No description provided.

[robodoo]

Pull request status dashboard.

[nmarotte]

Hey @xpl-odoo @jcs-odoo , I've applied suggestions we discussed last time, except for a few TODO this is almost ready for review, would you mind checking it out to see how it is ?

Thanks a lot :)

[nmarotte]

Hello @xpl-odoo , I've applied your suggested changes and preemptively adapted the other upgrade page that was not reviewed yet (it is definitely not perfect but hopefully it should make your review faster haha). Don't hesitate to fix typos or simple rephrasing on the fly, if that's easier for you. Otherwise, don't worry I will take the time to fix them :)

Thanks again a lot for your help !

[avg-odoo]

@xpl-odoo Hi - FYI level of the urgency has decreased here since we want our head of dept to review the content

[augustoPerez]

Hi @nmarotte
I added the comments for the first part of the documentation
I excluded the Upgrade for developers page for the moment, as it needs to be refactored

[augustoPerez]

It's not super clear what all this valid mean

[nmarotte]

Part of the current documentation : https://www.odoo.com/documentation/16.0/administration/upgrade/odoo_sh.html#overview

I think it refers to the branch being up and running

[augustoPerez]

IMO, it was meant for:
"valid projects": projects with a valid subscription (that are still paying), so for example no trial subscriptions, or educational ones (don't know if they exist on SH)
and "valid production build": what you said.

But it's still seems confusing.

I think we could ask STS (he developed the feature and knows the conditions he added in the code)

Hi @sts-odoo
Could you help us understand what you meant when you wrote this note in the documentation?

What does "valid project" and "valid production build" means?

[sts-odoo]

@augustoPerez @nmarotte I confirm that it means a valid project (running odoo.sh subsrciption on odoo.com not a trial one, ie partnership), AND a valid subcription for the database (running based on odoo.com status).

In other places in the UI of Odoo.sh customer will see if their database is valid or not and why so it is clear enough. The documentation should be complementary to the UI not a copy or replacement of the messages that exist already in the UI.

@augustoPerez does the upgrade platform accepts non valid database to upgrade? If so, why, and do we want that as well on odoo.sh?

[nmarotte]

Hey @sts-odoo , indeed the upgrade platform only accepts database with a valid subscription number, so no subscription, no request. I changed the note to

The :guilabel:`Upgrade` tab is available for projects with a valid subscription.

since, indeed, if the production branch is red/killed/dropped, it would make no sense to upgrade it. Thanks for your input :D

[nmarotte]

Merged in #6274