Skip to content

Conversation

@rps-odoo
Copy link
Contributor

@rps-odoo rps-odoo commented Apr 24, 2024

@rps-odoo rps-odoo changed the title [IMP]: point of sale invoicing [IMP] accounting/l10n_ec: point of sale invoicing Apr 24, 2024
@robodoo
Copy link
Collaborator

robodoo commented Apr 24, 2024

Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rps-odoo, thanks again for the PR! I implemented 2/4 of your images and made a few small RST syntax edits in 5d25f4d. This PR should now be ready for review. :)

@samueljlieber
Copy link
Contributor

b3de21d Rebased to resolve a conflict due to #8522 adding the eCommerce section to ecuador.rst

@samueljlieber samueljlieber changed the base branch from 17.0 to master May 13, 2024 18:52
@samueljlieber samueljlieber changed the base branch from master to 17.0 May 13, 2024 18:52
@C3POdoo C3POdoo requested a review from a team May 13, 2024 18:53
@dade-odoo dade-odoo requested a review from LoredanaLrpz May 14, 2024 08:27
Copy link
Contributor

@dade-odoo dade-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm passing this on to the PoS master @LoredanaLrpz since she handles PoS documentation, but if you need anything from the accounting team, feel free to reach out!

@rps-odoo
Copy link
Contributor Author

Hi @LoredanaLrpz hope you are doing good! Do you got any updates/comments on this document PR? Thanks! cc @samueljlieber

Copy link
Contributor

@LoredanaLrpz LoredanaLrpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rps-odoo, thank you for your work, and sorry for the delay.
Here's my review and suggestions :)
Have a nice day!

@auva-odoo auva-odoo self-requested a review June 27, 2024 12:47
@samueljlieber
Copy link
Contributor

Thank you @LoredanaLrpz for your helpful review! I implemented most of your suggestions in e158e73.

@rps-odoo can you help me with this remaining one: #8962 (comment)

@samueljlieber
Copy link
Contributor

Thank you @rps-odoo, I implemented your change in b679428 as well as added a seealso to link to the POS documentation on receipts and invoices in the QR code section.

@LoredanaLrpz this PR is ready for another look, TIA 🙏

Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since @LoredanaLrpz is currently off, I reviewed her comments and made some changes accordingly. I also took the opportunity to fix a few minor issues in the eCommerce workflow section just above. I hope you don't mind.

If you’re okay with my changes, you can r+ whenever you're ready. Thanks again!

@robodoo delegate+

@samueljlieber
Copy link
Contributor

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants