-
Notifications
You must be signed in to change notification settings - Fork 10.8k
[IMP] accounting/l10n_ec: point of sale invoicing #8962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d3600e6 to
5d25f4d
Compare
samueljlieber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5d25f4d to
b3de21d
Compare
dade-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm passing this on to the PoS master @LoredanaLrpz since she handles PoS documentation, but if you need anything from the accounting team, feel free to reach out!
|
Hi @LoredanaLrpz hope you are doing good! Do you got any updates/comments on this document PR? Thanks! cc @samueljlieber |
LoredanaLrpz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rps-odoo, thank you for your work, and sorry for the delay.
Here's my review and suggestions :)
Have a nice day!
b3de21d to
e158e73
Compare
|
Thank you @LoredanaLrpz for your helpful review! I implemented most of your suggestions in e158e73. @rps-odoo can you help me with this remaining one: #8962 (comment) |
e158e73 to
b679428
Compare
|
Thank you @rps-odoo, I implemented your change in b679428 as well as added a seealso to link to the POS documentation on receipts and invoices in the QR code section. @LoredanaLrpz this PR is ready for another look, TIA 🙏 |
b679428 to
1e10ce7
Compare
auva-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since @LoredanaLrpz is currently off, I reviewed her comments and made some changes accordingly. I also took the opportunity to fix a few minor issues in the eCommerce workflow section just above. I hope you don't mind.
If you’re okay with my changes, you can r+ whenever you're ready. Thanks again!
@robodoo delegate+
|
@robodoo r+ |
Task: #3864339
Link to GDrive images folder: https://drive.google.com/drive/folders/1S5XmaPh2vnTgJAXB26PgBpnuvVgaxOL9?usp=drive_link