[IMP] CRM: updated some of the menu naming conventions as well as did a grammar pass. #925

vpk-odoo · 2021-04-01T20:56:49Z

Task: https://www.odoo.com/web#id=2496900&action=333&active_id=3835&model=project.task&view_type=form&cids=3&menu_id=4720

crm/track_leads/lead_scoring.rst

xpl-odoo · 2021-04-09T08:03:36Z

You also need to add a Label to your PR on GitHub (in most cases it will be "content improvement") and a Milestone (here, v14)
I'll let you do it :)

xpl-odoo

Good job with the changes, it's a lot better! I have been very nitpicky - don't be afraid by the number of comments :)

Note, I just learned the following:

the commit message title shouldn't be longer than 72 characters, here there are 85. ([IMP] CRM: updated some of the menu naming conventions as well as did a grammar pass.)
You should also include the Odoo task number in the commit message (the .txt file you edit on PyCharm). It can be found on the task URL. Here is the one for your task
And include a link to the Odoo task on GitHub (i.e. when you submit the PR message on GitHub, which uses your commit message as a basis)

content/applications/sales/crm/track_leads/lead_scoring.rst

xpl-odoo

We are good to go! There might be a comma or two we could add (according to Grammarly), but I don't feel they are necessary. But maybe Jon will think otherwise :)

jcs-odoo

Thanks for the PR @vpk-odoo and for the review @xpl-odoo !

I'm afraid I may have bad news though.
I'm wondering if you checked the content of CRM with the PO or an expert?

I think this feature is already deprecated. As a matter of fact, it is even completely removed in 14.2, but this doc is about 14.0 so it is still slightly valid.

As a rule of thumb, if a feature is useful for the current version, then we should expect to see it in the settings, and not in a module to install. (this is not always true, but it's a rule of thumb :p )

I think that this old module has been replaced by the "Predictive Lead Scoring" feature, which works with "AI", based on the previous results of your opportunities. I am quite sure it also impacts Leads. However, in 14.0 lead assignation and multi-sales teams are still in this "lead scoring" module, but this is moved directly into CRM from 14.2. So the "assignation" part is still good.

(For info, there will probably be databases in 14.3 but they will have to deal with the doc about 14.0 until we also update it for 15.0)

I'm afraid this PR isn't valid as is, normally. (For real, it pains me to write this). But please double-check with the experts, they would know better than I do :)
I guess we can still merge it as it is an improvement. Just make sure that you'll cover the new feature in another PR.

It's not enough to understand the old docs and update them: we must ask PO/experts/colleagues about the apps, make sure to understand it fully, and only then rewrite the content. By starting "from scratch", you can get rid of weird structures that some docs may have, and make sure that your content is relevant for the current version and well structured.

Thank you,
Jonathan

content/applications/sales/crm/track_leads/lead_scoring.rst

jcs-odoo · 2021-06-02T13:49:36Z

content/applications/sales/crm/track_leads/lead_scoring.rst

 Evaluate & use the unassigned leads
 ===================================


same as above, about the ampersand

content/applications/sales/crm/track_leads/lead_scoring.rst

jcs-odoo · 2021-06-02T14:58:41Z

@vpk-odoo @xpl-odoo
I forgot the part about fixing the conflicts:

git checkout 14.0 + git pull to update your local 14.0
checkout your branch
git rebase 14.0

You'll have some conflicts to fix. Here is a short video showing how to do it:
https://drive.google.com/file/d/1ITESVzMao7IrhhStsR7vJ7IwN9W4b4q2/view

vpk-odoo · 2021-06-24T16:15:48Z

@jcs-odoo and @xpl-odoo, pretty sure that I was able to fix the conflicts. I added a "warning" at the top of the page that this feature would be completely deprecated in V14.3.

robodoo · 2022-03-22T14:10:24Z

Sorry, I didn't know about this PR and had to retrieve its information, you may have to re-approve it.

robodoo · 2022-03-22T14:10:26Z

Pull request status dashboard.

StraubCreative · 2022-04-22T19:45:34Z

@jcs-odoo how best to proceed here?
I'm guessing just pick back up with 14.0 rebase and then have @meng-odoo review it?

Thank you + please advise 🙏

jcs-odoo · 2022-04-26T11:24:31Z

(For info, there will probably be databases in 14.3 but they will have to deal with the doc about 14.0 until we also update it for 15.0)

Hello @StraubCreative and many thanks for taking this one :)

Technically speaking... yes, a good rebase on the latest 14.0 would be a great start.
Then @meng-odoo can directly apply some changes if needed.

I don't remember the details, but I think there were issues with versioning at the time. It's mainly because we didn't have branches for intermediary versions at the time.

Careful though, as it probably implies that the content won't be valid for versions >=14.3 .

As a rule of thumb, I would say to merge the improvement if they're ready to go (I haven't re-read the diff since my old review) and focus more on current content rather than on old features that have no future. That's why we primarily work based on master or the last frozen version.

Cheers :)

StraubCreative · 2022-04-29T23:44:21Z

Technically speaking... yes, a good rebase on the latest 14.0 would be a great start. Then @meng-odoo can directly apply some changes if needed.

Ok, @jcs-odoo thanks for clarifying.
The branch has been rebased via ddae5da.
@meng-odoo you're up :)

I don't remember the details, but I think there were issues with versioning at the time. It's mainly because we didn't have branches for intermediary versions at the time.

Careful though, as it probably implies that the content won't be valid for versions >=14.3 .

For this part @jcs-odoo, what do you think about including a Note or similar section at the top of the doc mentioning which versions these features apply to? Would this be useful? Open to ideas...

jcs-odoo · 2022-05-05T11:59:47Z

I don't remember the details, but I think there were issues with versioning at the time. It's mainly because we didn't have branches for intermediary versions at the time.
Careful though, as it probably implies that the content won't be valid for versions >=14.3 .

For this part @jcs-odoo, what do you think about including a Note or similar section at the top of the doc mentioning which versions these features apply to? Would this be useful? Open to ideas...

No, let's avoid any mention of the version as it often ends up unmaintained. Also, that's why we have a version switcher: people read the documentation they need, according to their version of Odoo.
You simply adapt the content from the version needed and that's it :)

Technically speaking there are two ways to do so:

either indicate to the fw-bot to create PR up to a specific branches, and you create a different PR from that version.
you merge the primary branch, let GitHub create all the forward-port branches, then you checkout the branch that needs some changes, force-push the changes, then merge. (the "next" branches in the forward-port chain are updated as well after the force-push)

Cheers :)

meng-odoo

Hi @StraubCreative, I changed the wording in this doc to be clear, concise, and instructional as we've previously discussed. Please let me know if you have any more suggestions :)

@jcs-odoo Regarding your comment from Jun 2, 2021, I'm planning to create a brand new doc on Predictive Lead Scoring in collaboration with the product expert, Jessica (ebj), to replace this one for v15 :)

content/applications/sales/crm/track_leads/lead_scoring.rst

meng-odoo · 2022-05-05T20:25:41Z

content/applications/sales/crm/track_leads/lead_scoring.rst

+Here's an example of a scoring rule for English-speaking Canadian users. You can modify your rules
+to match whatever criteria you want to score leads on, and you can add as many criteria as you would
+like.


Edited for wording and clarification.

Suggested change

Here's an example of a scoring rule for English-speaking Canadian users. You can modify your rules

to match whatever criteria you want to score leads on, and you can add as many criteria as you would

like.

Here's an example of a scoring rule for leads from Canada that have English listed as their language. Customize your rules to fit the needs of your business, and add as many criteria as you want.

Might have to come back to this. We should refrain from saying anything along the lines of "look at this image to understand x". Images are supplemental alongside text descriptions, not the sole focus for instruction.

Let's delete that entire first sentence; the paragraph is fine without it.

content/applications/sales/crm/track_leads/lead_scoring.rst

StraubCreative · 2022-05-12T22:34:31Z

@meng-odoo 5/5 change requests implemented on 7ed91f9.

Please let me know if we need anything else :)

content/applications/sales/crm/track_leads/lead_scoring.rst

meng-odoo · 2022-05-17T21:00:19Z

content/applications/sales/crm/track_leads/lead_scoring.rst

+Here's an example of a scoring rule for English-speaking Canadian users. You can modify your rules
+to match whatever criteria you want to score leads on, and you can add as many criteria as you would
+like.


Let's delete that entire first sentence; the paragraph is fine without it.

meng-odoo

Hi @StraubCreative! On this pass, I deleted the sentence that directly refers to an image, and fixed a couple other small things that I missed before. Thanks :)

content/applications/sales/crm/track_leads/lead_scoring.rst

Task ID: 2496900

StraubCreative · 2022-05-17T23:59:35Z

@meng-odoo your latest batch of change requests from today (5/17) have been made on 174c483.

Please let me know if there's anything else before we pass off to DR :)

meng-odoo

Hey @StraubCreative thanks for making those changes. Everything looks good to me! I'll tag Doc Review.

AntoineVDV

@robodoo r+

Task ID: 2496900 closes #925 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>

xpl-odoo requested changes Apr 8, 2021

View reviewed changes

vpk-odoo added the content improvement label Apr 9, 2021

vpk-odoo added this to the 14.0 milestone Apr 9, 2021

vpk-odoo force-pushed the 14.0-crm-leadscoring-vpk branch 2 times, most recently from 68bfbbc to 4851e8e Compare May 25, 2021 16:49

xpl-odoo requested changes May 27, 2021

View reviewed changes

xpl-odoo mentioned this pull request May 27, 2021

[IMP] CRM: updating flow and screenshots about lead mining #998

Closed

vpk-odoo force-pushed the 14.0-crm-leadscoring-vpk branch 2 times, most recently from 3f03a00 to d751f2c Compare May 27, 2021 22:19

xpl-odoo approved these changes May 28, 2021

View reviewed changes

jcs-odoo requested changes Jun 2, 2021

View reviewed changes

vpk-odoo force-pushed the 14.0-crm-leadscoring-vpk branch from d751f2c to 70ed79a Compare June 24, 2021 15:57

C3POdoo requested a review from a team December 9, 2021 11:26

jcs-odoo closed this Mar 22, 2022

jcs-odoo reopened this Mar 22, 2022

StraubCreative self-assigned this Apr 22, 2022

StraubCreative force-pushed the 14.0-crm-leadscoring-vpk branch from 70ed79a to ddae5da Compare April 29, 2022 23:37

meng-odoo suggested changes May 5, 2022

View reviewed changes

AntoineVDV removed the content improvement label May 6, 2022

StraubCreative force-pushed the 14.0-crm-leadscoring-vpk branch from ddae5da to 7ed91f9 Compare May 12, 2022 22:32

StraubCreative requested a review from meng-odoo May 12, 2022 22:34

meng-odoo reviewed May 17, 2022

View reviewed changes

meng-odoo suggested changes May 17, 2022

View reviewed changes

content/applications/sales/crm/track_leads/lead_scoring.rst Outdated Show resolved Hide resolved

content/applications/sales/crm/track_leads/lead_scoring.rst Outdated Show resolved Hide resolved

[IMP] CRM: updated lead scoring with note about deprecation

174c483

Task ID: 2496900

StraubCreative force-pushed the 14.0-crm-leadscoring-vpk branch from 7ed91f9 to 174c483 Compare May 17, 2022 23:56

StraubCreative requested a review from meng-odoo May 17, 2022 23:59

meng-odoo approved these changes May 18, 2022

View reviewed changes

meng-odoo requested a review from a team May 18, 2022 17:08

AntoineVDV approved these changes May 19, 2022

View reviewed changes

robodoo pushed a commit that referenced this pull request May 19, 2022

[IMP] CRM: updated lead scoring with note about deprecation

fca684e

Task ID: 2496900 closes #925 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>

robodoo closed this May 19, 2022

robodoo temporarily deployed to merge May 19, 2022 11:12 Inactive

fw-bot deleted the 14.0-crm-leadscoring-vpk branch June 2, 2022 11:47

		Evaluate & use the unassigned leads
		===================================

[IMP] CRM: updated some of the menu naming conventions as well as did a grammar pass. #925

[IMP] CRM: updated some of the menu naming conventions as well as did a grammar pass. #925

Uh oh!

Conversation

vpk-odoo commented Apr 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xpl-odoo commented Apr 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xpl-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xpl-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

jcs-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jcs-odoo Jun 2, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jcs-odoo commented Jun 2, 2021

Uh oh!

vpk-odoo commented Jun 24, 2021

Uh oh!

robodoo commented Mar 22, 2022

Uh oh!

robodoo commented Mar 22, 2022

Uh oh!

StraubCreative commented Apr 22, 2022

Uh oh!

jcs-odoo commented Apr 26, 2022

Uh oh!

StraubCreative commented Apr 29, 2022

Uh oh!

jcs-odoo commented May 5, 2022

Uh oh!

meng-odoo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

meng-odoo May 5, 2022

Choose a reason for hiding this comment

Uh oh!

StraubCreative May 12, 2022

Choose a reason for hiding this comment

Uh oh!

meng-odoo May 17, 2022

Choose a reason for hiding this comment

Uh oh!

vpk-odoo commented Apr 1, 2021 •

edited

Loading

xpl-odoo commented Apr 9, 2021 •

edited

Loading

meng-odoo left a comment •

edited

Loading