[IMP] CRM: updating flow and screenshots about lead mining #998

vpk-odoo · 2021-05-26T17:15:39Z

No description provided.

… a grammar pass.

xpl-odoo

This PR seems to include your previous PR. I'm not knowledgeable enough so I'm summoning @jcs-odoo to check what's happening :)

xpl-odoo · 2021-05-27T13:49:23Z

content/applications/sales/crm/acquire_leads/lead_mining.rst

 ==============

-For this feature to work, go to :menuselection:`CRM --> Configuration --> Settings` and activate the **Lead Mining** feature.
+For this feature to work, go to :menuselection:`CRM --> Configuration --> Settings` and activate


Suggested change

For this feature to work, go to :menuselection:`CRM --> Configuration --> Settings` and activate

Go to :menuselection:`CRM --> Configuration --> Settings` and activate

"For this feature to work" seems superfluous. Feel free to keep that little 'intro' if you prefer though :)

xpl-odoo · 2021-05-27T13:51:32Z

content/applications/sales/crm/acquire_leads/lead_mining.rst

 =======================
-In any business, getting quality leads is essential to keep the business growing. Lead mining allows you to generate leads from scratch directly from your database.
-Target your leads based on a set of criteria such as the country, the size of the company, the industry your leads are coming from to make them relevant to your business.
+In any business, getting quality leads is essential to keep the business growing. Lead mining


Suggested change

In any business, getting quality leads is essential to keep the business growing. Lead mining

For any company, getting quality leads is essential to keep the business growing. Lead mining

Nitpicking, but I would try to avoid repetitions when they aren't necessary (i.e., when you use precise terms to describe Odoo features, fields etc., which of course should not be re-named: ))

xpl-odoo · 2021-05-27T13:57:36Z

content/applications/sales/crm/acquire_leads/lead_mining.rst

 =======================
 Lead mining
 =======================


From the content guidelines:

For each formatting line (e.g., ===), write as many symbols (=) as there are characters in the header.

Here you can remove 12 equal signs above and below the heading

xpl-odoo · 2021-05-27T13:58:15Z

content/applications/sales/crm/acquire_leads/lead_mining.rst

+leads are relevant to your business.

 Configuration
 ==============


Suggested change

==============

=============

One too many "="

xpl-odoo · 2021-05-27T13:59:03Z

content/applications/sales/crm/acquire_leads/lead_mining.rst

+   :alt: Activating Lead Mining

 Start generating leads
 ==========================


Suggested change

==========================

======================

Four too many "="

xpl-odoo · 2021-05-27T14:53:14Z

content/applications/sales/crm/acquire_leads/lead_mining.rst

+   :alt: Buy Credits from Lead Mining Setting

-.. image:: media/LM7.png
+.. image:: lead_mining/LM7.png


There is a lot of blank space on that screenshot. I would try to use a similar width for both screenshots as they are displayed one after the other

xpl-odoo · 2021-05-27T14:55:38Z

content/applications/sales/crm/track_leads/lead_scoring.rst

@@ -1,78 +1,79 @@
 =============================
 Assign leads based on scoring


I'm not sure what happened here, but the changes from your first PR are also included here. @jcs-odoo can you check what's going on here?

xpl-odoo · 2021-05-27T14:58:40Z

content/applications/sales/crm/acquire_leads/lead_mining.rst

-
-
-.. image:: media/LM5.png
+.. image:: lead_mining/generate-leads-popup.png


Don't forget to pngquant your screenshots :)

xpl-odoo · 2021-05-27T14:59:05Z

content/applications/sales/crm/acquire_leads/lead_mining.rst

 :menuselection:`Leads --> Leads` where you have the **Generate Leads** button.

-.. image:: media/LM2.png
+.. image:: lead_mining/generate-leads-button.png


Don't forget to pngquant your screenshots :)

xpl-odoo · 2021-05-27T15:03:09Z

content/applications/sales/crm/acquire_leads/lead_mining.rst

+Additional options you can choose from are:
+* **Size**: filter leads depending on the number of employees in the companies.
+* **Country**: pick the countries leads are coming from. Pick multiple countries, if applicable.
+* **Industry**: pick the industries leads are coming from. Pick multiple industries, if applicable.
+* **Salesperson**: choose who on the Sales Team will be assigned these leads.
+* **Sales Team**: choose which Sales Team will be assigned to these leads
+* **Tags**: choose what tags are added directly to the leads once found.


Suggested change

Additional options you can choose from are:

* **Size**: filter leads depending on the number of employees in the companies.

* **Country**: pick the countries leads are coming from. Pick multiple countries, if applicable.

* **Industry**: pick the industries leads are coming from. Pick multiple industries, if applicable.

* **Salesperson**: choose who on the Sales Team will be assigned these leads.

* **Sales Team**: choose which Sales Team will be assigned to these leads

* **Tags**: choose what tags are added directly to the leads once found.

Additional options you can choose from are:

- **Size**: filter leads depending on the number of employees in the companies.

- **Country**: pick the countries leads are coming from. Pick multiple countries, if applicable.

- **Industry**: pick the industries leads are coming from. Pick multiple industries, if applicable.

- **Salesperson**: choose who on the Sales Team will be assigned these leads.

- **Sales Team**: choose which Sales Team will be assigned to these leads

- **Tags**: choose what tags are added directly to the leads once found.

I assume you wanted to have a list here? I think you need to have an empty line before starting a list. I never used *, that's why I replaced them with -, but * should work as well.

jcs-odoo · 2021-06-02T08:16:37Z

This PR seems to include your previous PR. I'm not knowledgeable enough so I'm summoning @jcs-odoo to check what's happening :)

not to worry, @xpl-odoo ! git rebase is our best friend in situations like these.

I assume @vpk-odoo, that you based this branch on the previous one, either by mistake, or because you edited the same document in another branch (while the PR wasn't merged yet). So we'll make sure to merge the other PR first, and then, you'll have a good basis to rebase this branch here. There is no real use to do it before that, since you'll have to rebase on a "usable" 14.0 if you want your PR to be applicable.

Now, I'll explain in videos how to do this, as I think you never had to resolve conflicts before. (no worries, it's really normal as well)

So I focus first on the other PR so we can have a clean base here :)

StraubCreative · 2022-04-22T18:38:08Z

Follow up on this @jcs-odoo @xpl-odoo

The PR seems out-of-date and VPK no longer active.
@meng-odoo and I would like to take it over.

For how we may proceed, which path do you recommend we follow:

we submit a new PR off a fresh 14.0 pull, and cherry-pick VPK's edits on top of it along with XPL's change requests
OR
stay on this PR, rebase 14.0, solve the merge conflicts, and address change requests here (think this depends on the status of the previous PR which was closed and then reopened?)

Thanks and please let us know 🙏

AntoineVDV · 2022-04-29T09:05:56Z

@StraubCreative Hi, both are okay. It's like for task: it depends on whether you find it easier to do a fresh start or not, want to keep the review history or not, etc. From a git point of view, the same commit is going to be merged at the end either way.

Task: 2543815 Cherry pick from #998 Omitted changes proposed in the **track_leads** directory (e.g. `lead_scoring.rst` + image folder). Both the content and image updates were already pushed from another PR so what was proposed on #998 was outdated and no longer necessary. What’s left over are the original proposed changes in #998, within the **acquire_leads** directory which include updates to `lead_mining.rst` and corresponding image files. On top of these proposals, I went ahead and made the following changes: - renamed the image files in the asset directory, since they were using outdated naming convention (e.g. LM1.png, LM6.png, LM7.png) - cleaned up rst formatting issues (headings, line breaks, added guilabels, etc.) - rewrote document so content was more concise + followed content guidelines. You can see the first version of proposals here to compare the changes made.

StraubCreative · 2022-07-31T22:11:47Z

Continuing this PR as cherry-pick on #2535.
Closing thread.

robodoo · 2022-07-31T22:12:18Z

Sorry, I didn't know about this PR and had to retrieve its information, you may have to re-approve it.

robodoo · 2022-07-31T22:12:19Z

Pull request status dashboard.

Task: 2543815 Cherry pick from #998 Omitted changes proposed in the **track_leads** directory (e.g. `lead_scoring.rst` + image folder). Both the content and image updates were already pushed from another PR so what was proposed on #998 was outdated and no longer necessary. What’s left over are the original proposed changes in #998, within the **acquire_leads** directory which include updates to `lead_mining.rst` and corresponding image files. On top of these proposals, I went ahead and made the following changes: - renamed the image files in the asset directory, since they were using outdated naming convention (e.g. LM1.png, LM6.png, LM7.png) - cleaned up rst formatting issues (headings, line breaks, added guilabels, etc.) - rewrote document so content was more concise + followed content guidelines. You can see the first version of proposals here to compare the changes made.

Task: 2543815 Cherry pick from #998 Omitted changes proposed in the **track_leads** directory (e.g. `lead_scoring.rst` + image folder). Both the content and image updates were already pushed from another PR so what was proposed on #998 was outdated and no longer necessary. What’s left over are the original proposed changes in #998, within the **acquire_leads** directory which include updates to `lead_mining.rst` and corresponding image files. On top of these proposals, I went ahead and made the following changes: - renamed the image files in the asset directory, since they were using outdated naming convention (e.g. LM1.png, LM6.png, LM7.png) - cleaned up rst formatting issues (headings, line breaks, added guilabels, etc.) - rewrote document so content was more concise + followed content guidelines. You can see the first version of proposals here to compare the changes made. closes #2535 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>

Task: 2543815 Cherry pick from #998 Omitted changes proposed in the **track_leads** directory (e.g. `lead_scoring.rst` + image folder). Both the content and image updates were already pushed from another PR so what was proposed on #998 was outdated and no longer necessary. What’s left over are the original proposed changes in #998, within the **acquire_leads** directory which include updates to `lead_mining.rst` and corresponding image files. On top of these proposals, I went ahead and made the following changes: - renamed the image files in the asset directory, since they were using outdated naming convention (e.g. LM1.png, LM6.png, LM7.png) - cleaned up rst formatting issues (headings, line breaks, added guilabels, etc.) - rewrote document so content was more concise + followed content guidelines. You can see the first version of proposals here to compare the changes made. X-original-commit: 02ef871

Task: 2543815 Cherry pick from #998 Omitted changes proposed in the **track_leads** directory (e.g. `lead_scoring.rst` + image folder). Both the content and image updates were already pushed from another PR so what was proposed on #998 was outdated and no longer necessary. What’s left over are the original proposed changes in #998, within the **acquire_leads** directory which include updates to `lead_mining.rst` and corresponding image files. On top of these proposals, I went ahead and made the following changes: - renamed the image files in the asset directory, since they were using outdated naming convention (e.g. LM1.png, LM6.png, LM7.png) - cleaned up rst formatting issues (headings, line breaks, added guilabels, etc.) - rewrote document so content was more concise + followed content guidelines. You can see the first version of proposals here to compare the changes made. closes #3118 X-original-commit: 02ef871 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>

Task: 2543815 Cherry pick from #998 Omitted changes proposed in the **track_leads** directory (e.g. `lead_scoring.rst` + image folder). Both the content and image updates were already pushed from another PR so what was proposed on #998 was outdated and no longer necessary. What’s left over are the original proposed changes in #998, within the **acquire_leads** directory which include updates to `lead_mining.rst` and corresponding image files. On top of these proposals, I went ahead and made the following changes: - renamed the image files in the asset directory, since they were using outdated naming convention (e.g. LM1.png, LM6.png, LM7.png) - cleaned up rst formatting issues (headings, line breaks, added guilabels, etc.) - rewrote document so content was more concise + followed content guidelines. You can see the first version of proposals here to compare the changes made. X-original-commit: 2416a2e

Task: 2543815 Cherry pick from #998 Omitted changes proposed in the **track_leads** directory (e.g. `lead_scoring.rst` + image folder). Both the content and image updates were already pushed from another PR so what was proposed on #998 was outdated and no longer necessary. What’s left over are the original proposed changes in #998, within the **acquire_leads** directory which include updates to `lead_mining.rst` and corresponding image files. On top of these proposals, I went ahead and made the following changes: - renamed the image files in the asset directory, since they were using outdated naming convention (e.g. LM1.png, LM6.png, LM7.png) - cleaned up rst formatting issues (headings, line breaks, added guilabels, etc.) - rewrote document so content was more concise + followed content guidelines. You can see the first version of proposals here to compare the changes made. closes #3128 X-original-commit: 2416a2e Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com> Signed-off-by: Zachary Straub <zst@odoo.com>

Task: 2543815 Cherry pick from #998 Omitted changes proposed in the **track_leads** directory (e.g. `lead_scoring.rst` + image folder). Both the content and image updates were already pushed from another PR so what was proposed on #998 was outdated and no longer necessary. What’s left over are the original proposed changes in #998, within the **acquire_leads** directory which include updates to `lead_mining.rst` and corresponding image files. On top of these proposals, I went ahead and made the following changes: - renamed the image files in the asset directory, since they were using outdated naming convention (e.g. LM1.png, LM6.png, LM7.png) - cleaned up rst formatting issues (headings, line breaks, added guilabels, etc.) - rewrote document so content was more concise + followed content guidelines. You can see the first version of proposals here to compare the changes made. closes #3130 X-original-commit: 2416a2e Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com> Signed-off-by: Zachary Straub <zst@odoo.com>

Task: 2543815 Cherry pick from #998 Omitted changes proposed in the **track_leads** directory (e.g. `lead_scoring.rst` + image folder). Both the content and image updates were already pushed from another PR so what was proposed on #998 was outdated and no longer necessary. What’s left over are the original proposed changes in #998, within the **acquire_leads** directory which include updates to `lead_mining.rst` and corresponding image files. On top of these proposals, I went ahead and made the following changes: - renamed the image files in the asset directory, since they were using outdated naming convention (e.g. LM1.png, LM6.png, LM7.png) - cleaned up rst formatting issues (headings, line breaks, added guilabels, etc.) - rewrote document so content was more concise + followed content guidelines. You can see the first version of proposals here to compare the changes made. closes #3129 X-original-commit: 2416a2e Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com> Signed-off-by: Zachary Straub <zst@odoo.com>

Task: 2543815 Cherry pick from #998 Omitted changes proposed in the **track_leads** directory (e.g. `lead_scoring.rst` + image folder). Both the content and image updates were already pushed from another PR so what was proposed on #998 was outdated and no longer necessary. What’s left over are the original proposed changes in #998, within the **acquire_leads** directory which include updates to `lead_mining.rst` and corresponding image files. On top of these proposals, I went ahead and made the following changes: - renamed the image files in the asset directory, since they were using outdated naming convention (e.g. LM1.png, LM6.png, LM7.png) - cleaned up rst formatting issues (headings, line breaks, added guilabels, etc.) - rewrote document so content was more concise + followed content guidelines. You can see the first version of proposals here to compare the changes made. closes #3131 X-original-commit: 2416a2e Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com> Signed-off-by: Zachary Straub <zst@odoo.com>

[IMP] CRM: updated some of the menu naming conventions as well as did…

4851e8e

… a grammar pass.

vpk-odoo added the content improvement label May 26, 2021

vpk-odoo added this to the 14.0 milestone May 26, 2021

vpk-odoo requested a review from xpl-odoo May 26, 2021 17:15

[IMP] CRM: Updating screenshots and info about Lead Mining

da36d9c

vpk-odoo force-pushed the 14.0-crm-lead-mining-vpk branch from 289be92 to da36d9c Compare May 26, 2021 17:17

xpl-odoo requested changes May 27, 2021

View reviewed changes

jcs-odoo requested a review from a team December 9, 2021 11:37

StraubCreative self-assigned this Apr 22, 2022

AntoineVDV removed the content improvement label May 6, 2022

StraubCreative mentioned this pull request Jul 31, 2022

[IMP] CRM: updating flow and screenshots about lead mining #2535

Closed

StraubCreative closed this Jul 31, 2022

fw-bot mentioned this pull request Dec 6, 2022

[FW][IMP] CRM: updating flow and screenshots about lead mining #3118

Closed

This was referenced Dec 7, 2022

[FW][IMP] CRM: updating flow and screenshots about lead mining #3128

Closed

[FW][IMP] CRM: updating flow and screenshots about lead mining #3129

Closed

fw-bot mentioned this pull request Dec 7, 2022

[FW][IMP] CRM: updating flow and screenshots about lead mining #3130

Closed

fw-bot mentioned this pull request Dec 7, 2022

[FW][IMP] CRM: updating flow and screenshots about lead mining #3131

Closed

	For this feature to work, go to :menuselection:`CRM --> Configuration --> Settings` and activate
	Go to :menuselection:`CRM --> Configuration --> Settings` and activate

	In any business, getting quality leads is essential to keep the business growing. Lead mining
	For any company, getting quality leads is essential to keep the business growing. Lead mining

		@@ -1,78 +1,79 @@
		=============================
		Assign leads based on scoring



		.. image:: media/LM5.png
		.. image:: lead_mining/generate-leads-popup.png

[IMP] CRM: updating flow and screenshots about lead mining #998

[IMP] CRM: updating flow and screenshots about lead mining #998

Uh oh!

Conversation

vpk-odoo commented May 26, 2021

Uh oh!

xpl-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xpl-odoo May 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jcs-odoo commented Jun 2, 2021

Uh oh!

StraubCreative commented Apr 22, 2022

Uh oh!

AntoineVDV commented Apr 29, 2022

Uh oh!

StraubCreative commented Jul 31, 2022

Uh oh!

robodoo commented Jul 31, 2022

Uh oh!

robodoo commented Jul 31, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

xpl-odoo May 27, 2021 •

edited

Loading