[IMP] CRM: updating flow and screenshots of generating leads

[vpk-odoo]

Associated Task: https://www.odoo.com/web#id=2540813&action=333&active_id=3835&model=project.task&view_type=form&cids=3&menu_id=4720

[xpl-odoo]

When I do make html (or make clean html or make fast), I got 3 warnings that need to be fixed:

C:\Users\Odoo\Documents\documentation-user\content\applications\sales\crm\acquire_leads.rst:5: WARNING: toctree contains reference to nonexisting document 'applications/sales/crm/acquire_leads/generate_from_email'

Whenever you remove, rename, move or create a new doc page, the toctree, the table of content, needs to be updated as well. Toctrees are located one folder 'up' from the actual file. So let's take the CRM app as an example: the CRM folder only contains toctree files actually. They are the table of content of what's inside each folder located under the CRM folder (one toctree per subfolder - so five toctree .rst in the case of the CRM folder. In your case, as you removed generate_from_email.rst you also need to remove the reference to the file in the toctree 'above' it (acquire_leads.rst).

TLDR: remove line 9 - acquire_leads/generate_from_email - from the toctree .rst file acquire_leads.rst located under applications\sales\crm

C:\Users\Odoo\Documents\documentation-user\content\applications\sales\crm\acquire_leads\generate_from_website.rst:: WARNING: image file not readable: applications/sales/crm/acquire_leads/generate_from_website/form-building-blocks.png

The second warning is easier to understand: the file form-building-blocks.png doesn't exist, which is why it isn't "readable". In your .rst, you refer to .. image:: generate_from_website/form-building-blocks.png on line 66. Yet, in the folder containing your images, I see form-building-block.png with "block" instead of "blocks", which is most likely the file you wanted to use. So you need to either change the image file name or the reference to the file name in your .rst!

TLDR: rename the image form-building-block.png to form-building-blocks.png

C:\Users\Odoo\Documents\documentation-user\content\applications\sales\crm\acquire_leads\generate_from_website.rst:105: WARNING: unknown document: ../sales/crm/acquire_leads/convert

The :doc: directive link on line 106 isn't correct. To properly use the doc directive, you need to think: where is this file in relation to where I'm? When it's in the same folder, it's easy: you just use the file name. In this case, :doc:`convert`
If you wanted to link another CRM doc from another folder, for example, gamification.rst in the optimize folder, you need to check at which point the file paths diverge. For this example, everything before the optimize folder is the same, and you simply use ../ to say that. Then you add the part of the path which isn't the same, i.e.: optimize/gamification. So you end up with :doc:`../optimize/gamification`. The same logic applies everywhere.
@jcs-odoo I believe the RST cheat sheet could be clearer about using the relative file path, don't you think?

TLDR: the link to the doc on line 106 isn't correct: use :doc:`convert` instead of :doc:`../sales/crm/acquire_leads/convert`

Let me know if my explanations are clear enough! Or if you knew that all along and just forgot to use make html 😬

[xpl-odoo]

Don't forget to check my general comments on the PR's conversation :)

[xpl-odoo]

We are almost there! A couple of comments are about things I forgot to mention in the first reviews, sorry about that

[xpl-odoo]

Nice job Tori! 👍
Just fix the filename issue and then I will move the task to the next stage for Jon to review (no need for me to review this once again).

[vpk-odoo]

@xpl-odoo, we should be good to go now!

[meng-odoo]

@StraubCreative Hi Zach! I'm sorry this review is so huge. I made tons of changes to VPK's wording for consistency, clarity, and brevity. Please let me know if you have any questions/comments about my changes below :) Thanks

[robodoo]

Sorry, I didn't know about this PR and had to retrieve its information, you may have to re-approve it.

[robodoo]

Pull request status dashboard.

[StraubCreative]

Hi @meng-odoo 👋
First batch of revisions are complete!
Please review latest on 1709e52.

As well, please see my feedback on the following comments:

• Lines 14-17, contextualize navigation + remove 2nd person
• Line 23, heading clarification
• Lines 62-65, continuous present
• Lines 69-72, continuous present + rephrasing

After addressing these (let me know if you agree/disagree and I'll act accordingly), and performing your broader review to the latest commit, I'd like to ask to please do a "2nd person familiar" cleanup like we did other PR 🙏

Thanks and please let me know what further changes you'd like to see so we can pass to Doc Review.

[jcs-odoo]

Hello :)

I just wanted to comment about two things:

• error in the redirects.txt file (see comment)
• images are too heavy, probably because they're too large. If you take screenshots on a 4K screen, you can resize the images to 50%. #SEO #efficient #hashtag

I didn't read the rest of the PR, to be honest, it was just to give some comments.

Cheers :)

[meng-odoo]

Hey @StraubCreative! When I originally reviewed this, I hadn't yet seen your feedback on the other PR, which is why this one wasn't up to snuff :) This second pass should be better! Please let me know if you have any more suggestions. Thanks

[meng-odoo]

This section is talking specifically about the Contact Us page, which can contain a Contact Form or not. But I agree that it's confusing. Let's change it to "Use Contact Forms on your website", and I'll add a sentence to the beginning of this section to clarify.

[meng-odoo]

I'll fix the wording and I agree that this makes sense as a tip!

[StraubCreative]

@meng-odoo finished with 2nd round revisions (JCS fixes included) on e65181d.

Please review everything and let me know if we need anything else before tagging DR :)
(e.g. we may need to add :guilabel: in a few spots?
Also I need to squash all of our commits into VPK when we're good on our end.)

[meng-odoo]

Hey @StraubCreative! It looks like a couple of our edits didn't make it onto the most recent commit for some reason (I double checked that I pulled the latest one, e65181d). I also edited some ':guilabel:` formatting on this pass. Please see my comments below. Thanks!

[meng-odoo]

@StraubCreative The edits to this paragraph didn't make it onto the most recent commit. I'll copy the final edited version here:

Suggested change

under :menuselection:`CRM --> Configuration --> Sales Teams`.

Each Sales Team can use its own unique email alias to generate leads/opportunities. Any email sent to a Sales Team's email alias will automatically create a lead (if leads are activated in your CRM settings) or an opportunity in the pipeline for that particular team. Configure custom email aliases on the configuration page for each Sales Team by navigating to :menuselection:`CRM --> Configuration --> Sales Teams`.

[meng-odoo]

@StraubCreative The edits to this paragraph didn't make it onto the latest commit either. Here's the final edited version:

Suggested change

	soliciting certain information that needs filtering, such as suggestions, bug reports, etc.
	The *Form Builder* module is installed automatically when a Form element is added to a web page via the Website Builder. It can also be installed manually from the :guilabel:`Apps` page.

[StraubCreative]

@meng-odoo
your 5/9 change requests have been completed on 0ef316c.

As well, I squashed all of the commits into one so it'll be ready for DR when they're up.

Please review and let me know if you need anything else, thanks!

[meng-odoo]

@StraubCreative Thanks for making all those changes and squashes! Everything looks good to me. I'll go ahead and tag doc review :)

resolved

[StraubCreative]

Thank you for the review @AntoineVDV
Your changes have been made on df14502.

Please advise on the placement of the redirects per your comment above and do let me know if you need anything else too :)

[AntoineVDV]

The conflict would not have occurred because of another redirect rule but because the redirect rules for 15.0 are added at the end of the file, which is where VPK added the rule for this PR. Someday, I will split the redirect.txt file to have one file per version and avoid this kind of trouble.

[AntoineVDV]

@robodoo r+